Optimize performance for /api/-/query endpoints #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amvanbaren Could you update description like here: #350 (comment)? thank you 🙏 |
amvanbaren
force-pushed
the
feature/issue-356
branch
from
eda6dba
to
5f63493
Compare
Reduced database queries Use DTOs instead of managed entities Fixed unittests Added Gatling simulation
amvanbaren
force-pushed
the
feature/issue-356
branch
from
5f63493
to
7700719
Compare
akosyakov
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
@amvanbaren thanks for clarifications 🙏 good to see concrete numbers
This was referenced Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To measure performance I created
server/src/gatling/scala/org/eclipse/openvsx/RegistryAPIGetQuerySimulation.scalaTo run it:
./gradlew --rerun-tasks gatlingRun-org.eclipse.openvsx.RegistryAPIGetQuerySimulationI saw 2.5x more requests, try to reproduce and if it works please approve
Fixes #356
Changes:
Reduced database queries
Use DTOs instead of managed entities
Fixed unittests
Added Gatling simulation