Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some extension resource url return 404 or 500 #435

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

amvanbaren
Copy link
Contributor

@amvanbaren amvanbaren commented Mar 23, 2022

Fixes #432

Added publisher displayName
Added /vscode/unpkg endpoint to VSCodeAdapter
Removed WEB_RESOURCE, instead use RESOURCE
FileResource java migration
Updated /vscode/extensionquery tests to include web resources
Added /vscode/asset tests for web resources

Testing steps

Display name and 404 status

  • Update VS Code product.json:
"extensionsGallery": {
    "serviceUrl": "http://localhost:8080/vscode/gallery",
    "itemUrl": "http://localhost:8080/vscode/item",
    "resourceUrlTemplate": "http://localhost:8080/vscode/unpkg/{publisher}/{name}/{version}/{path}"
},
  • Restart VS Code if it is running, to apply the changes to product.json
  • Publish a couple extensions where the package.json returned 404:
    • viper-admin.viper 2.4.0
    • huacat.office-theme 1.1.3
    • PKief.material-product-icons 1.1.2
  • Open developer tools in VS Code (Help > Toggle Developer Tools)
  • Browse color themes in VS Code by navigating to Manage > Color Themes > + Browse Additional Color Themes...
  • The color theme quick pick list should now display the publisher name as the last part of each item, e.g. ∙ viper-admin (instead of ∙ null)
  • The developer tools should not contain 404 statuses for package.json files.

500 status

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After

This is for the 404s, but the 500s now work as well!

LGTM, will follow up with gitpod-io/openvscode-server#331.

@filiptronicek
Copy link
Member

Gitpod snapshot for quick testing: https://gitpod.io#snapshot/4ab090aa-2c13-46b1-be66-a4df7a7aecda.

Added browse endpoint to VSCodeAdapter
Removed WEB_RESOURCE, instead use RESOURCE
FileResource java migration
Updated web resource tests
@amvanbaren amvanbaren merged commit ec8c510 into eclipse:master Apr 4, 2022
@jeanp413
Copy link
Contributor

jeanp413 commented Apr 4, 2022

Awesome, thanks @amvanbaren and @filiptronicek

amvanbaren added a commit to amvanbaren/openvsx that referenced this pull request Apr 5, 2022
Some extension resource url return 404 or 500
amvanbaren added a commit to EclipseFdn/open-vsx.org that referenced this pull request May 22, 2022
eclipse/openvsx#457
eclipse/openvsx#434
eclipse/openvsx#429
eclipse/openvsx#443
eclipse/openvsx#435
eclipse/openvsx#442
eclipse/openvsx#406
eclipse/openvsx#433
eclipse/openvsx#424
[feat: Add support for X-Forwarded-Prefix](eclipse/openvsx@ea2cde9)
eclipse/openvsx#419
eclipse/openvsx#421
eclipse/openvsx#422
eclipse/openvsx#410

Dependabot updates:
[Bump ajv from 6.12.2 to 6.12.6 in /webui](eclipse/openvsx@f475efa)
[Bump follow-redirects from 1.14.7 to 1.14.8 in /cli](eclipse/openvsx@4f8445c)
[Bump pathval from 1.1.0 to 1.1.1 in /webui](eclipse/openvsx@a477256)
[Bump simple-get from 3.1.0 to 3.1.1 in /cli](eclipse/openvsx@2a2d537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some extension resource url return 404 or 500
3 participants