-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store and send missing fields in extension metadata #434
Conversation
@@ -130,6 +131,7 @@ private ExtensionVersion createExtensionVersion(ExtensionProcessor processor, Us | |||
} | |||
} | |||
|
|||
extension.setLastUpdatedDate(extVersion.getTimestamp()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there other events where setLastUpdatedDate
should be called, e.g. extension activated/deactivated or version removed?
@amvanbaren is this ready for review? if so @filiptronicek could you take a look |
# Conflicts: # server/src/main/java/org/eclipse/openvsx/ExtensionService.java # server/src/main/java/org/eclipse/openvsx/adapter/VSCodeAdapter.java # server/src/main/java/org/eclipse/openvsx/dto/ExtensionDTO.java # server/src/main/java/org/eclipse/openvsx/entities/Extension.java # server/src/main/jooq-gen/org/eclipse/openvsx/jooq/tables/Extension.java # server/src/main/jooq-gen/org/eclipse/openvsx/jooq/tables/records/ExtensionRecord.java # server/src/test/java/org/eclipse/openvsx/RegistryAPITest.java # server/src/test/java/org/eclipse/openvsx/adapter/VSCodeAdapterTest.java
3c26855
to
ca5400f
Compare
Yes, it's ready for review. @filiptronicek can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eclipse/openvsx#457 eclipse/openvsx#434 eclipse/openvsx#429 eclipse/openvsx#443 eclipse/openvsx#435 eclipse/openvsx#442 eclipse/openvsx#406 eclipse/openvsx#433 eclipse/openvsx#424 [feat: Add support for X-Forwarded-Prefix](eclipse/openvsx@ea2cde9) eclipse/openvsx#419 eclipse/openvsx#421 eclipse/openvsx#422 eclipse/openvsx#410 Dependabot updates: [Bump ajv from 6.12.2 to 6.12.6 in /webui](eclipse/openvsx@f475efa) [Bump follow-redirects from 1.14.7 to 1.14.8 in /cli](eclipse/openvsx@4f8445c) [Bump pathval from 1.1.0 to 1.1.1 in /webui](eclipse/openvsx@a477256) [Bump simple-get from 3.1.0 to 3.1.1 in /cli](eclipse/openvsx@2a2d537)
Fixes #330
Testing steps
psql
, query:The
published_date
andlast_updated_date
columns should have timestamp values./extensionquery
endpoint:The response should contain
releaseDate
,publishedDate
andlastUpdated
fieldsredhat.vscode-yaml
. ThelastUpdated
/last_updated_date
should be updated to current timestamp.psql
to revert the migration:Restart the server. Once the server is running you can check that
published_date
andlast_updated_date
columns are added and have timestamp values, usingpsql
: