sync #948
Merged
sync #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
…ple-bpns' into chore/849-notifications-to-multiple-bpns
…ation-2 chore(dependabot): XXX upgrade dependencies
…tend-feedback Feature/918 merge parts frontend feedback
Update Dependencies Backend
…fication creation.
…fication creation.
chore-xxx: updated testdata file
…ions-on-own-bpn Feature/783 reject notifications on own bpn
chore(helm):778 adding counterPartyId to catalog request.
Update Dependencies Backend
…ultiple-bpns chore(concept): #849 create concept
…ions chore(helm):783 fixxed environment import
chore(helm):783 upgrade irs
…model chore(concept): #831 create concept
Update Dependencies Backend
…egration/notification/EditNotificationIT.java
…ions chore(backend):783 added validation to notification service not allowing…
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -74,7 +74,7 @@ | |||
| throw new InvestigationReceiverBpnMismatchException("BPN of sender cannot be null."); | |||
| } | |||
| if (applicationBPN.value().equals(senderBPN)) { | |||
| throw new NotificationSenderAndReceiverBPNEqualException(BPN.of(senderBPN), edcNotification.getNotificationId()); | |||
| throw new NotificationSenderAndReceiverBPNEqualException(senderBPN, Long.valueOf(edcNotification.getNotificationId())); | |||
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
chore(helm):783 update irs lib to release version
ds-mwesener
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
Changed
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: