Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Data Provisioning Adaption to Industry Core Conformity #837

Closed
5 tasks done
Assignees
Labels
backend Backend related issues data_ingest Issues regarding the Feature of data ingest public public and not spammy R24.5 release-hot-fix pbi is relevant for current release and for hotfix path spillover temporary label for spill over

Comments

@ds-lcapellino
Copy link
Contributor

ds-lcapellino commented Apr 9, 2024

As a admin,
I want to import data into trace-x
so that I have conformity to AAS 3 and can provision the data within the catena network.

Hints / Details

The story #602 implemented a filter mechanism for the digital twin type. We need to make sure that our data provisioning workflow also considers that new filter mechanism.

UPDATES

Acceptance Criteria

  • Detection of BomLifecyle is done based on specificAssetId "digitalTwinType"
  • Update documentation that bomLifecylce detection is based on Industry Core attribute "digitalTwinType"
  • Lookup works
  • Validation works for all supported aspect types
  • Data Provisioning is functional or story to make it work again has been derived

Out of Scope

  • ...
@ds-lcapellino ds-lcapellino moved this to backlog in Trace-X Apr 9, 2024
@ds-mwesener ds-mwesener changed the title digitalTwinType in subsequential flow [Backend] Data Provisioning Adaption to CX-Conformity Apr 9, 2024
@mkanal mkanal changed the title [Backend] Data Provisioning Adaption to CX-Conformity [Backend] Data Provisioning Adaption to Industry Core Conformity Apr 9, 2024
@mkanal mkanal added the data_ingest Issues regarding the Feature of data ingest label Apr 9, 2024
@mkanal mkanal moved this from backlog to next in Trace-X Apr 9, 2024
@ds-mwesener ds-mwesener added the backend Backend related issues label Apr 16, 2024
@ds-mwesener ds-mwesener moved this from next to wip in Trace-X Apr 22, 2024
@ds-mwesener ds-mwesener self-assigned this Apr 22, 2024
@ds-mwesener ds-mwesener moved this from wip to test in Trace-X Apr 29, 2024
@ds-mwesener
Copy link
Contributor

Currently waiting for: #778 to be able to test successfully.

@mkanal mkanal reopened this Apr 30, 2024
@RazvanZmau RazvanZmau added the spillover temporary label for spill over label Apr 30, 2024
@ds-mmaul ds-mmaul added the R24.5 label Apr 30, 2024
ds-mwesener added a commit that referenced this issue May 2, 2024
feature: #837 use digitalTwinType for shell lookup, #603 upgrade aspect models
@ds-mwesener ds-mwesener moved this from test to wip in Trace-X May 8, 2024
@ds-lcapellino ds-lcapellino mentioned this issue May 8, 2024
2 tasks
@ds-mwesener
Copy link
Contributor

ds-mwesener commented May 8, 2024

Currently the models used to map the payload are old. Those needs to be updated to align to the real submodels. To avoid failing through validation on submodel payload validation in irs.
-> Switching GenericSubmodel to IrsSubmodel class and extend IrsSubmodel with rawPayload

@ds-mwesener
Copy link
Contributor

The provisioning works with the following PR: catenax-ng#1240

@ds-mwesener
Copy link
Contributor

Open todos:

  1. adapt specific asset ids in dtr service - see urn:uuid:b0acf3e1-3fbe-46c0-aa0b-0724caae7772
  2. Make sure if corrupt json file is uploaded that the response is still 400 and not 500.

@mkanal mkanal reopened this May 14, 2024
@ds-mwesener ds-mwesener added the release-hot-fix pbi is relevant for current release and for hotfix path label May 14, 2024
@ds-mwesener
Copy link
Contributor

Derived story for tractionBatteryCode: #988

@ds-crehm
Copy link
Contributor

Tested on dev / test:
Data provisioning works in general. Validation is working and shows relevant error information.
There is an issue with parts that have a tractionBatteryCode, which will be fixed by the ticket linked by @ds-mwesener.
Ready for review.

@ds-crehm ds-crehm assigned mkanal and unassigned ds-mwesener and ds-crehm May 16, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X May 16, 2024
@mkanal mkanal added the public public and not spammy label Jun 5, 2024
@mkanal mkanal moved this from review to done in Trace-X Jun 10, 2024
@mkanal
Copy link
Contributor

mkanal commented Jun 10, 2024

PO acceptance in behalf of @jzbmw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues data_ingest Issues regarding the Feature of data ingest public public and not spammy R24.5 release-hot-fix pbi is relevant for current release and for hotfix path spillover temporary label for spill over
Projects
Status: done
6 participants