Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Merge Other Parts into Parts #918

Closed
2 tasks
ds-ashanmugavel opened this issue Apr 30, 2024 · 6 comments · Fixed by catenax-ng/tx-traceability-foss#1210 or catenax-ng/tx-traceability-foss#1222
Assignees
Labels
frontend_refactoring Issues regarding a specific design change in trace-x frontend Frontend related Issues

Comments

@ds-ashanmugavel
Copy link
Contributor

ds-ashanmugavel commented Apr 30, 2024

As a User,
I want to have data which is in the same category to be in the same place,
so that I have a single and whole source of data of one category.

Hints / Details

  • Miro UI Concept Board : LINK

Image

  • Merge Parts and Other Parts in main navigation to Parts
  • Split between Lifecycle as currently, but other parts should also be included
  • Refactor necessary parts of application to merge to inbox (facades, services, states, detailed views etc.. )
  • DISCUSSION NEEDED: Also BE change to merge API ?
  • DISCUSSION NEEDED: Alignment of models parts and other parts

Acceptance Criteria

  • otherParts are merged into Parts
  • no code left specifically for other Parts

Out of Scope

  • adjustment of the part table changes
  • Backend
@ds-ashanmugavel ds-ashanmugavel added frontend Frontend related Issues backend Backend related issues DISCUSSION_NEEDED This ticket needs discussion within teammembers frontend_refactoring Issues regarding a specific design change in trace-x labels Apr 30, 2024
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Apr 30, 2024
@ds-ashanmugavel
Copy link
Contributor Author

I copied the ticket as the original tickets were deleted due to a spam account.
Orginal Ticket: #627

@ds-mmaul ds-mmaul moved this from inbox to next in Trace-X Apr 30, 2024
@jzbmw jzbmw removed the backend Backend related issues label Apr 30, 2024
@ds-mmaul ds-mmaul removed the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Apr 30, 2024
@ds-mwesener ds-mwesener moved this from next to wip in Trace-X May 1, 2024
@ds-mwesener ds-mwesener self-assigned this May 1, 2024
@ds-mwesener
Copy link
Contributor

ds-mwesener commented May 3, 2024

  1. Create quality notification should be able to update the type. 👍
  2. Remove create alert button (right side) 👍
  3. Opacity and no cursor if disabled 👍
  4. Tooltip quality topic should always be visible no matter if not allowed 👍
  5. Back button should do a browser back and not get back to inbox always 👍
  6. Bug notification type not correctly set after change from own to supplier parts 👍
  7. OWN -> Eigen, Supplier = Lieferant, Customer = Kunde 👍
  8. Camel case on Own column 👍
  9. Align Content: center - on quick filter (Own, Supplier, Customer) 👍
  10. Background after selection on: full-width icon
  11. Tooltip on Full Width 👍
  12. Publish Icon same behaviour as quality notification create 👍
    13 Icons -> ml3 👍

@ds-mwesener
Copy link
Contributor

ds-mwesener commented May 7, 2024

Open todos:
If quick filter on owner is activated - the pagination throws errors. 👍
Normal Case on Enum Fields within AutoComplete 👍
Owner, Semantisches Datenmodell (also consider to map tombstone) 👍

@ds-crehm
Copy link
Contributor

ds-crehm commented May 8, 2024

Tested on E2E-A and E2E-B. Looks good to me. All of my feedback in discussions with @ds-mwesener was already implemented.

After the mock-up was created, other changes were done to the frontend. Those had to be considered in the implementation. Those changes were not updated in the mock-up, so there are some discrepancies between mock-up and actual implementation.

Ready for review.

@ds-crehm ds-crehm reopened this May 8, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm May 8, 2024
@ds-crehm ds-crehm moved this from test to review in Trace-X May 8, 2024
@ds-crehm
Copy link
Contributor

ds-crehm commented May 8, 2024

One addition: The dashboard still shows 'parts' and 'other parts':
grafik
This was not in scope for this ticket. This will be done during the refactoring of the dashboard:
#926
#927

@ds-lcapellino ds-lcapellino mentioned this issue May 8, 2024
2 tasks
@mkanal mkanal assigned ds-mwesener and unassigned mkanal May 13, 2024
@mkanal mkanal moved this from review to done in Trace-X May 13, 2024
@mkanal
Copy link
Contributor

mkanal commented May 13, 2024

PO acceptance in behalf of @jzbmw. Works as intended.

@mkanal mkanal closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend_refactoring Issues regarding a specific design change in trace-x frontend Frontend related Issues
Projects
Status: done
6 participants