chore(backend):783 added validation to notification service not allowing… #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Integration Test Results342 tests 341 ✅ 1m 38s ⏱️ For more details on these failures, see this check. Results for commit 11e2127. ♻️ This comment has been updated with latest results. |
Unit Test Results210 tests 210 ✅ 19s ⏱️ Results for commit 11e2127. ♻️ This comment has been updated with latest results. |
✅ No Dependency Check findings were found |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -74,7 +74,7 @@ | |||
| throw new InvestigationReceiverBpnMismatchException("BPN of sender cannot be null."); | |||
| } | |||
| if (applicationBPN.value().equals(senderBPN)) { | |||
| throw new NotificationSenderAndReceiverBPNEqualException(BPN.of(senderBPN), edcNotification.getNotificationId()); | |||
| throw new NotificationSenderAndReceiverBPNEqualException(senderBPN, Long.valueOf(edcNotification.getNotificationId())); | |||
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
|
ds-mwesener
changed the title
...test/java/org/eclipse/tractusx/traceability/integration/notification/EditNotificationIT.java
Outdated
Show resolved
Hide resolved
…egration/notification/EditNotificationIT.java
ds-lcapellino
approved these changes
May 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… bpn mismatch
resolves eclipse-tractusx#783