-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #10007: [core] fix typo for ApplicationShell method #10020
fix #10007: [core] fix typo for ApplicationShell method #10020
Conversation
Signed-off-by: Shraddha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@5hraddha thank you for your changes 👍
Please be sure to sign the eclipse contributor agreement (eca) with the same email as your authorship so we can accept your changes.
Signed-off-by: Shraddha <[email protected]>
Sure @vince-fugnitto. I signed the eclipse contributor agreement (eca) just now. Thank you!! |
Signed-off-by: Shraddha <[email protected]>
Signed-off-by: Shraddha <[email protected]>
Signed-off-by: Shraddha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@5hraddha unfortunately the changes will likely need to be rebased again (we had a patch release fix for 1.17.2
). In any case the changelog entry still looked incorrect:
Signed-off-by: Shraddha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like another rebase is necessary, this time it should be much easier as the template is now created. All that's required is to add the entry directly (we can merge after :))
@5hraddha are you still interested in contributing the pull-request? |
Yeah @vince-fugnitto I would push the changes today. Thanks for checking with me. |
Signed-off-by: Shraddha <[email protected]>
Signed-off-by: Shraddha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@5hraddha thank you for the changes, the pull-request now looks good 👍
Thank you so much @vince-fugnitto for being so patient with me. |
The commit fixes a typo in the `ApplicationShell` method `setTopPanelVisibily`. The method was renamed to `setTopPanelVisibility` and a note was added to the changelog as a potential breaking change. Signed-off-by: Shraddha <[email protected]>
The commit fixes a typo in the `ApplicationShell` method `setTopPanelVisibily`. The method was renamed to `setTopPanelVisibility` and a note was added to the changelog as a potential breaking change. Signed-off-by: Shraddha <[email protected]>
Signed-off-by: Shraddha [email protected]
What it does
Fixes #10007
setTopPanelVisibily
is renamed tosetTopPanelVisibility
How to test
setTopPanelVisibility
getting referenced properly in the packageReview checklist
Reminder for reviewers