Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10007: [core] fix typo for ApplicationShell method #10020

Merged

Conversation

5hraddha
Copy link
Contributor

@5hraddha 5hraddha commented Aug 31, 2021

Signed-off-by: Shraddha [email protected]

What it does

Fixes #10007
setTopPanelVisibily is renamed to setTopPanelVisibility

How to test

  • Check all the instances of setTopPanelVisibility getting referenced properly in the package

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5hraddha thank you for your changes 👍

Please be sure to sign the eclipse contributor agreement (eca) with the same email as your authorship so we can accept your changes.

CHANGELOG.md Outdated Show resolved Hide resolved
@5hraddha
Copy link
Contributor Author

@5hraddha thank you for your changes 👍

Please be sure to sign the eclipse contributor agreement (eca) with the same email as your authorship so we can accept your changes.

Sure @vince-fugnitto. I signed the eclipse contributor agreement (eca) just now. Thank you!!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5hraddha unfortunately the changes will likely need to be rebased again (we had a patch release fix for 1.17.2). In any case the changelog entry still looked incorrect:

Screen Shot 2021-09-01 at 3 10 31 PM

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like another rebase is necessary, this time it should be much easier as the template is now created. All that's required is to add the entry directly (we can merge after :))

@vince-fugnitto
Copy link
Member

@5hraddha are you still interested in contributing the pull-request?

@5hraddha
Copy link
Contributor Author

5hraddha commented Sep 8, 2021

@5hraddha are you still interested in contributing the pull-request?

Yeah @vince-fugnitto I would push the changes today. Thanks for checking with me.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Shraddha <[email protected]>
@vince-fugnitto vince-fugnitto added the quality issues related to code and application quality label Sep 9, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5hraddha thank you for the changes, the pull-request now looks good 👍

@vince-fugnitto vince-fugnitto merged commit a6bfede into eclipse-theia:master Sep 9, 2021
@5hraddha
Copy link
Contributor Author

5hraddha commented Sep 9, 2021

@5hraddha thank you for the changes, the pull-request now looks good 👍

Thank you so much @vince-fugnitto for being so patient with me.

RomanNikitenko pushed a commit that referenced this pull request Sep 16, 2021
The commit fixes a typo in the `ApplicationShell` method `setTopPanelVisibily`.
The method was renamed to `setTopPanelVisibility` and a note was added to the changelog as a potential breaking change.

Signed-off-by: Shraddha <[email protected]>
RomanNikitenko pushed a commit that referenced this pull request Sep 16, 2021
The commit fixes a typo in the `ApplicationShell` method `setTopPanelVisibily`.
The method was renamed to `setTopPanelVisibility` and a note was added to the changelog as a potential breaking change.

Signed-off-by: Shraddha <[email protected]>
@vince-fugnitto vince-fugnitto added this to the 1.18.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: fix typo for ApplicationShell method
2 participants