fix #10007: [core] fix typo for ApplicationShell method (#10020)

The commit fixes a typo in the `ApplicationShell` method `setTopPanelVisibily`. The method was renamed to `setTopPanelVisibility` and a note was added to the changelog as a potential breaking change. Signed-off-by: Shraddha <[email protected]>
eclipse-theia · Sep 16, 2021 · 0cf10ca · 0cf10ca
1 parent 9445076
commit 0cf10ca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 
 - [core] added `BreadcrumbsRendererFactory` to constructor arguments of `DockPanelRenderer` and `ToolbarAwareTabBar`. [#9920](https://github.com/eclipse-theia/theia/pull/9920)
 - [task] `TaskDefinition.properties.required` is now optional to align with the specification [#10015](https://github.com/eclipse-theia/theia/pull/10015)
+- [core] `setTopPanelVisibily` renamed to `setTopPanelVisibility` [#10020](https://github.com/eclipse-theia/theia/pull/10020)
 
 ## v1.17.2 - 9/1/2021
 

diff --git a/packages/core/src/browser/shell/application-shell.ts b/packages/core/src/browser/shell/application-shell.ts
@@ -264,11 +264,11 @@ export class ApplicationShell extends Widget {
 
         if (!environment.electron.is()) {
             this.corePreferences.ready.then(() => {
-                this.setTopPanelVisibily(this.corePreferences['window.menuBarVisibility']);
+                this.setTopPanelVisibility(this.corePreferences['window.menuBarVisibility']);
             });
             this.corePreferences.onPreferenceChanged(preference => {
                 if (preference.preferenceName === 'window.menuBarVisibility') {
-                    this.setTopPanelVisibily(preference.newValue);
+                    this.setTopPanelVisibility(preference.newValue);
                 }
             });
         }
@@ -301,7 +301,7 @@ export class ApplicationShell extends Widget {
         this.activeChanged.connect(updateFocusContextKeys);
     }
 
-    protected setTopPanelVisibily(preference: string): void {
+    protected setTopPanelVisibility(preference: string): void {
         const hiddenPreferences = ['compact', 'hidden'];
         this.topPanel.setHidden(hiddenPreferences.includes(preference));
     }