Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix typo for ApplicationShell method #10007

Closed
vince-fugnitto opened this issue Aug 31, 2021 · 1 comment · Fixed by #10020
Closed

core: fix typo for ApplicationShell method #10007

vince-fugnitto opened this issue Aug 31, 2021 · 1 comment · Fixed by #10020
Assignees
@5hraddha
Labels
beginners issues that are perfect for beginners good first issue good first issues for new contributors

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

There is a typo in the method present under ApplicationShell:

theia/packages/core/src/browser/shell/application-shell.ts

Lines 296 to 299 in 7442150

protected setTopPanelVisibily(preference: string): void {
const hiddenPreferences = ['compact', 'hidden'];
this.topPanel.setHidden(hiddenPreferences.includes(preference));
}

setTopPanelVisibily should be renamed to setTopPanelVisibility

As part of the changes we should also add an entry in the changelog for breaking changes.
@vince-fugnitto vince-fugnitto added beginners issues that are perfect for beginners good first issue good first issues for new contributors labels Aug 31, 2021
@5hraddha
Copy link
Contributor

Hi @vince-fugnitto , I would like to take this issue up. Could you please assign it to me?

5hraddha added a commit to 5hraddha/theia that referenced this issue Aug 31, 2021
@5hraddha
fix eclipse-theia#10007: [core] fix typo for ApplicationShell method
254e7f3 
Signed-off-by: Shraddha <[email protected]>
@5hraddha 5hraddha mentioned this issue Aug 31, 2021
Merged
1 task
vince-fugnitto pushed a commit that referenced this issue Sep 9, 2021
@5hraddha
fix #10007: [core] fix typo for ApplicationShell method (#10020)
a6bfede 
The commit fixes a typo in the `ApplicationShell` method `setTopPanelVisibily`.
The method was renamed to `setTopPanelVisibility` and a note was added to the changelog as a potential breaking change.

Signed-off-by: Shraddha <[email protected]>
RomanNikitenko pushed a commit that referenced this issue Sep 16, 2021
@5hraddha @RomanNikitenko
fix #10007: [core] fix typo for ApplicationShell method (#10020)
0cf10ca 
The commit fixes a typo in the `ApplicationShell` method `setTopPanelVisibily`.
The method was renamed to `setTopPanelVisibility` and a note was added to the changelog as a potential breaking change.

Signed-off-by: Shraddha <[email protected]>
RomanNikitenko pushed a commit that referenced this issue Sep 16, 2021
@5hraddha @RomanNikitenko
fix #10007: [core] fix typo for ApplicationShell method (#10020)
62f51c5 
The commit fixes a typo in the `ApplicationShell` method `setTopPanelVisibily`.
The method was renamed to `setTopPanelVisibility` and a note was added to the changelog as a potential breaking change.

Signed-off-by: Shraddha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@5hraddha 5hraddha

Labels
beginners issues that are perfect for beginners good first issue good first issues for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #10007: [core] fix typo for ApplicationShell method 5hraddha/theia
2 participants
@5hraddha @vince-fugnitto