Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10007: [core] fix typo for ApplicationShell method #10020

Merged
merged 8 commits into from
Sep 9, 2021
Merged

fix #10007: [core] fix typo for ApplicationShell method #10020

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
254e7f3
fix #10007: [core] fix typo for ApplicationShell method
5hraddha Aug 31, 2021
5758c04
update the change log under correct version #
5hraddha Aug 31, 2021
9c366df
update the change log under correct version #
5hraddha Aug 31, 2021
b28c9fc
update the change log under correct version #
5hraddha Aug 31, 2021
7b87202
add the link to the pull request in the change log
5hraddha Sep 1, 2021
f0dedd9
add the link to the pull request in the change log
5hraddha Sep 1, 2021
6cd3d1c
rebase and update changelog
5hraddha Sep 9, 2021
301ce33
update changelog
5hraddha Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Change Log

## v1.19.0

<a name="breaking_changes_1.19.0">[Breaking Changes:](#breaking_changes_1.19.0)</a>

- [core] `setTopPanelVisibily` renamed to `setTopPanelVisibility` [#10020](https://github.com/eclipse-theia/theia/pull/10020)

## v1.18.0 - 9/30/2021
vince-fugnitto marked this conversation as resolved.
Show resolved Hide resolved

- [core, outline-view, file-system, workspace] added breadcrumbs contribution points and renderers to `core` and contributions to other packages. [#9920](https://github.com/eclipse-theia/theia/pull/9920)
Expand All @@ -8,6 +14,7 @@

- [core] added `BreadcrumbsRendererFactory` to constructor arguments of `DockPanelRenderer` and `ToolbarAwareTabBar`. [#9920](https://github.com/eclipse-theia/theia/pull/9920)
- [task] `TaskDefinition.properties.required` is now optional to align with the specification [#10015](https://github.com/eclipse-theia/theia/pull/10015)
- [core] `setTopPanelVisibily` renamed to `setTopPanelVisibility` [#10020](https://github.com/eclipse-theia/theia/pull/10020)

## v1.17.2 - 9/1/2021

Expand Down
6 changes: 3 additions & 3 deletions packages/core/src/browser/shell/application-shell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,11 +264,11 @@ export class ApplicationShell extends Widget {

if (!environment.electron.is()) {
this.corePreferences.ready.then(() => {
this.setTopPanelVisibily(this.corePreferences['window.menuBarVisibility']);
this.setTopPanelVisibility(this.corePreferences['window.menuBarVisibility']);
});
this.corePreferences.onPreferenceChanged(preference => {
if (preference.preferenceName === 'window.menuBarVisibility') {
this.setTopPanelVisibily(preference.newValue);
this.setTopPanelVisibility(preference.newValue);
}
});
}
Expand Down Expand Up @@ -301,7 +301,7 @@ export class ApplicationShell extends Widget {
this.activeChanged.connect(updateFocusContextKeys);
}

protected setTopPanelVisibily(preference: string): void {
protected setTopPanelVisibility(preference: string): void {
const hiddenPreferences = ['compact', 'hidden'];
this.topPanel.setHidden(hiddenPreferences.includes(preference));
}
Expand Down