Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit snabbdom to bugfix releases, remove inversify from dependencies #429

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Limit snabbdom to bugfix releases, remove inversify from dependencies #429

merged 1 commit into from
Feb 16, 2024

Conversation

spoenemann
Copy link
Contributor

@spoenemann
Copy link
Contributor Author

Once approved, I'll publish Sprotty 1.1.1 with this fix. Or should we apply only the snabbdom change, but exclude the inversify change in that bugfix release?

kaisalmen
kaisalmen reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss how to proceed.

packages/sprotty/package.json Show resolved Hide resolved
kaisalmen
kaisalmen approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spoenemann spoenemann merged commit c0e7745 into master Feb 16, 2024
2 checks passed
@spoenemann spoenemann deleted the fix-snabbdom branch February 16, 2024 09:04
@spoenemann spoenemann added this to the v1.2.0 milestone Feb 16, 2024
@spoenemann spoenemann mentioned this pull request Feb 16, 2024
Closed
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this pull request Apr 21, 2024
@tortmayr
GLSP-1320: Update dev config
b885ce2 
- Updates to latest version of @eclipse-glsp/dev
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)
- Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429
  Can be removed once eclipse-glsp/glsp#1253 is resolved
- Switch from lerna to lerna-lite
- Remove Jenkinsfile and migrate to github-actions CI workflows
  - Add CI workflow for PRs
  - Add publish next workflow for pushes on master
  - Add multi-platform workflow that can be executed manually  runs periodically (once per week)
  - Adapt code-analysis workflow to only run periodically (once a week) instead of on each PR


Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this pull request Apr 21, 2024
@tortmayr
GLSP-1320: Update dev config
4cb817a 
- Updates to latest version of @eclipse-glsp/dev
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)
- Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429
  Can be removed once eclipse-glsp/glsp#1253 is resolved
- Switch from lerna to lerna-lite
- Remove Jenkinsfile and migrate to github-actions CI workflows
  - Add CI workflow for PRs
  - Add publish next workflow for pushes on master
  - Add multi-platform workflow that can be executed manually  runs periodically (once per week)
  - Adapt code-analysis workflow to only run periodically (once a week) instead of on each PR


Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
@tortmayr tortmayr mentioned this pull request Apr 21, 2024
Merged
2 tasks
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this pull request Apr 21, 2024
@tortmayr
GLSP-1320: Update dev config
866053e 
- Updates to latest version of @eclipse-glsp/dev
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)
- Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429
  Can be removed once eclipse-glsp/glsp#1253 is resolved
- Switch from lerna to lerna-lite
- Remove Jenkinsfile and migrate to github-actions CI workflows
  - Add CI workflow for PRs
  - Add publish next workflow for pushes on master
  - Add multi-platform workflow that can be executed manually  runs periodically (once per week)
  - Adapt code-analysis workflow to only run periodically (once a week) instead of on each PR


Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this pull request Apr 21, 2024
@tortmayr
GLSP-1320: Update dev config
dc63dc4 
- Updates to latest version of @eclipse-glsp/dev
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)
- Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429
  Can be removed once eclipse-glsp/glsp#1253 is resolved


Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this pull request Apr 22, 2024
@tortmayr
GLSP-1320: Update to latest glsp dev config (#334)
1b6e6f3 
- Updates to latest version of @eclipse-glsp/dev
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)
- Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429
  Can be removed once eclipse-glsp/glsp#1253 is resolved


Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Fix versions of Sprotty dependencies
2 participants
@spoenemann @kaisalmen