Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inversify is a required dependency for non-webview extension code #1286

Closed
tortmayr opened this issue Mar 11, 2024 · 0 comments · Fixed by eclipse-glsp/glsp-client#334
Closed

Inversify is a required dependency for non-webview extension code #1286

tortmayr opened this issue Mar 11, 2024 · 0 comments · Fixed by eclipse-glsp/glsp-client#334
Labels
bug Something isn't working vscode

Comments

@tortmayr
Copy link
Contributor

Due to the utility inversify functions provided with @eclipse-glsp/protocol we have introduced a direct dependency to
inversify/reflect-metadata in the non-webview part of a GLSP vscode integration.

We don't use inversify in the extension code but still need the dependencies and the reflect-metadata imports due to the transitive
dependency of @eclipse-glsp/protocol.
Maybe we should consider to extract the inversify utilities into a separate package (e.g. @eclipse-glsp/di or @eclipse-glsp/inversify).
We could then reexport the symbols provided by this package in @eclipse-glsp/sprotty same as we do for @eclipse-glsp/protocol.
This would remove the dependency requirement in vscode (host) extensions and in addition, it would be possible to use those utilities in other projects without consuming the rest of @eclipse-glsp/protocol.
@tortmayr tortmayr added bug Something isn't working vscode labels Mar 11, 2024
@martin-fleck-at martin-fleck-at mentioned this issue Apr 18, 2024
Merged
2 tasks
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Apr 21, 2024
@tortmayr
GLSP-1320: Update dev config
b885ce2 
- Updates to latest version of @eclipse-glsp/dev
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)
- Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429
  Can be removed once eclipse-glsp/glsp#1253 is resolved
- Switch from lerna to lerna-lite
- Remove Jenkinsfile and migrate to github-actions CI workflows
  - Add CI workflow for PRs
  - Add publish next workflow for pushes on master
  - Add multi-platform workflow that can be executed manually  runs periodically (once per week)
  - Adapt code-analysis workflow to only run periodically (once a week) instead of on each PR


Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Apr 21, 2024
@tortmayr
GLSP-1320: Update dev config
4cb817a 
- Updates to latest version of @eclipse-glsp/dev
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)
- Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429
  Can be removed once eclipse-glsp/glsp#1253 is resolved
- Switch from lerna to lerna-lite
- Remove Jenkinsfile and migrate to github-actions CI workflows
  - Add CI workflow for PRs
  - Add publish next workflow for pushes on master
  - Add multi-platform workflow that can be executed manually  runs periodically (once per week)
  - Adapt code-analysis workflow to only run periodically (once a week) instead of on each PR


Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Apr 21, 2024
@tortmayr
GLSP-1320: Update dev config
866053e 
- Updates to latest version of @eclipse-glsp/dev
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)
- Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429
  Can be removed once eclipse-glsp/glsp#1253 is resolved
- Switch from lerna to lerna-lite
- Remove Jenkinsfile and migrate to github-actions CI workflows
  - Add CI workflow for PRs
  - Add publish next workflow for pushes on master
  - Add multi-platform workflow that can be executed manually  runs periodically (once per week)
  - Adapt code-analysis workflow to only run periodically (once a week) instead of on each PR


Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Apr 21, 2024
@tortmayr
GLSP-1320: Update dev config
dc63dc4 
- Updates to latest version of @eclipse-glsp/dev
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)
- Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429
  Can be removed once eclipse-glsp/glsp#1253 is resolved


Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Apr 22, 2024
@tortmayr
GLSP-1320: Update to latest glsp dev config (#334)
1b6e6f3 
- Updates to latest version of @eclipse-glsp/dev
- Add generate:index utility script
- Regenerate index files
- Fix codeActionsOnSave in vscode settings
- Refactor upgrade:next script
- Reformat code base with prettier
- Fix copyright headers (by running a full check with glsp checkHeaders . -t full)
- Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429
  Can be removed once eclipse-glsp/glsp#1253 is resolved


Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GLSP-1320: Update to latest glsp dev config eclipse-glsp/glsp-client
1 participant
@tortmayr