GLSP-1320: Update to latest glsp dev config #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
force-pushed
the
glsp-1320
branch
2 times, most recently
from
149b758
to
955cb87
Compare
martin-fleck-at
requested changes
Apr 18, 2024
tortmayr
force-pushed
the
glsp-1320
branch
3 times, most recently
from
4cb817a
to
866053e
Compare
- Updates to latest version of @eclipse-glsp/dev - Add generate:index utility script - Regenerate index files - Fix codeActionsOnSave in vscode settings - Refactor upgrade:next script - Reformat code base with prettier - Fix copyright headers (by running a full check with glsp checkHeaders . -t full) - Add resolutions for snabbdom to fix eclipse-sprotty/sprotty#429 Can be removed once eclipse-glsp/glsp#1253 is resolved Part of eclipse-glsp/glsp#1320 Fixes eclipse-glsp/glsp#1286
|
Thanks for the review @martin-fleck-at |
6 tasks
martin-fleck-at
requested changes
Apr 22, 2024
packages/protocol/src/.indexignore
Outdated
Comment on lines
1
to
2
| utils/test-util.ts | ||
| di |
There was a problem hiding this comment.
Nit: Could you please add some comments above each line as to why we are doing this? I don't think it is very obvious, e.g.,:
Suggested change
| utils/test-util.ts | |
| di | |
| # do not export test-util in index to avoid a necessary dependency on test frameworks such as chai | |
| # adopters can still use the functionality by importing it through the complete path | |
| utils/test-util.ts | |
| # do not export the DI utilities to avoid a necessary dependency on reflect-metadata | |
| di |
| "watch": "concurrently --kill-others -n tsc,standalone -c red,yellow \"tsc -b -w --preserveWatchOutput\" \"yarn -s standalone watch:bundle\"" | ||
| }, | ||
| "resolutions": { | ||
| "snabbdom": "~3.5.1" |
There was a problem hiding this comment.
Is there a particular reason we need to do this now?
There was a problem hiding this comment.
Well, I should have read the updated PR description. All good then ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Can be removed once Update to sprotty 1.2.0 glsp#1253 is resolved
Part of eclipse-glsp/glsp#1320
Fixes eclipse-glsp/glsp#1286
How to test
Follow-ups
Changelog