Update vite and vitest, compile and fix tests

[kaisalmen]

vite is now explicitly included as devDependency, so its version is more transparent.

There were a couple of undetected compilation errors in spec files. Therefore special tsconfig.test.json with noEmit=true have been added. They are included in the main compilation now. tsconfig.src.json cover the regular code compilation. tsconfig.json are required for vscode/eslint only now (we do the same in other projects, e.g. Langium). Alle "type": [] usages has been removed from tsconfig files as they shadows type issues. Therefore skipLibCheck is needed in test configs to shadow snabbdom and rollup type definition errors.

Node version in GitHub Action is upgraded to node 18. vite v5 requires it.
Volta instructions have been added.
Test were unstable with new default setting. Reason is unknown. It could be inversify not being safe with regard to concurrency, but that is speculation. pool is now configured to use only one worker thread.

inversify and reflect-metadata have been updated to ~6.0.2 and ~0.1.14 respectively.

[dhuebner]

@kaisalmen
I still see @injectable() is marked with an error:

Unable to resolve signature of class decorator when called as an expression.
  The runtime will invoke the decorator with 2 arguments, but the decorator expects 1.

Is it an inversify <-> typescript version mismatch?

[kaisalmen]

This should have been prevented by fixing the version to 6.0.1 (see description). It does not fail in GHA, that's why I think it is configured correctly. What does yarn list inversify say?

[dhuebner]

It says:

gitpod /workspace/sprotty (kaisalmen/vite-vitest-update) $ yarn list inversify
yarn list v1.22.21
warning Filtering by arguments is deprecated. Please use the pattern option instead.
└─ [email protected]

[dhuebner]

@kaisalmen
I also noticed that the tasks.json is outdated. Maybe it can be fixed in this PR as well?
Just remove "* All" and "* Example" tasks.

[kaisalmen]

Just remove "* All" and "* Example" tasks.

Done.

vscode related problems should be fixed.

Tests execution is instable. The test themselves are bot broken. Code issues are fixed. Happens more often in the pipeline. Don't know why, yet. Will investigate

[spoenemann]

Running the tests in Gitpod I get

 FAIL  packages/sprotty/src/base/commands/command-stack.spec.ts [ packages/sprotty/src/base/commands/command-stack.spec.ts ]
Error: Expression expected
 ❯ error node_modules/rollup/dist/es/shared/parseAst.js:337:30
 ❯ nodeConverters node_modules/rollup/dist/es/shared/parseAst.js:2084:9
 ❯ convertNode node_modules/rollup/dist/es/shared/parseAst.js:969:12
 ❯ convertProgram node_modules/rollup/dist/es/shared/parseAst.js:960:48
 ❯ parseAstAsync node_modules/rollup/dist/es/shared/parseAst.js:2150:20
 ❯ ssrTransformScript node_modules/vite/dist/node/chunks/dep-YJaePtkC.js:49505:15
 ❯ loadAndTransform node_modules/vite/dist/node/chunks/dep-YJaePtkC.js:49093:11

[kaisalmen]

Tests execution is instable. The test themselves are bot broken. Code issues are fixed. Happens more often in the pipeline. Don't know why, yet. Will investigate

It may be vitest problem. I am not sure, yet. Happens very rarely on Windows, more likely on Linux.

[kaisalmen]

@dhuebner and @spoenemann squashed all commits into one and removed all unrelated dependency changes. Dependency changes are only related to vite and vitest. vite v5 itself require node 18, so I kept that change.

All compiler adjustments and test fixes are kept as well.
I added volta instructions to all packages.json now, so everyone who uses it, now always has correct node and yarn versions.

The vitest instability is still not resolved. I am digging into this now...

[kaisalmen]

@dhuebner and @spoenemann this is now ready for review. Description is now up-to-date with performed changes.

[dhuebner]

No inversify type errors in the IDE, nice! :-) Tests are passing.
One thing we need to keep an eye on are regex inclusion exclusion patterns. We have a folder named lib in packages/sprotty/src/lib and the output folders are also named lib. However, right now it seams to work well!