-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error improvements per packages part1 #1994
Closed
3 tasks done
Comments
Hey team! Please add your planning poker estimate with Zenhub @hui-an-yang @roxaneletourneau @zainen |
Innkst
changed the title
Improve errors: first 5 package
Improve errors: first 5 packages
Jan 4, 2023
Innkst
changed the title
Improve errors: first 5 packages
Improve errors: first set of packages
Jan 11, 2023
Innkst
changed the title
Improve errors: first set of packages
Improve errors: set 1/3 of packages
Jan 11, 2023
hui-an-yang
added a commit
that referenced
this issue
Jan 13, 2023
hui-an-yang
added a commit
that referenced
this issue
Jan 13, 2023
hui-an-yang
added a commit
that referenced
this issue
Jan 16, 2023
hui-an-yang
added a commit
that referenced
this issue
Jan 16, 2023
hui-an-yang
added a commit
that referenced
this issue
Jan 16, 2023
hui-an-yang
added a commit
that referenced
this issue
Jan 17, 2023
hui-an-yang
added a commit
that referenced
this issue
Jan 18, 2023
Innkst
changed the title
Improve errors: set 1/3 of packages
Improve errors: set 1 of packages
Jan 18, 2023
Innkst
changed the title
Improve errors: set 1 of packages
Improve errors for all packages
May 2, 2023
hui-an-yang
added a commit
that referenced
this issue
May 9, 2023
…and improve across packages re #1994
hui-an-yang
added a commit
that referenced
this issue
May 9, 2023
hui-an-yang
added a commit
that referenced
this issue
May 9, 2023
…d improve across packages re #1994
hui-an-yang
added a commit
that referenced
this issue
May 9, 2023
…d improve across packages re #1994
hui-an-yang
added a commit
that referenced
this issue
May 9, 2023
hui-an-yang
added a commit
that referenced
this issue
May 9, 2023
hui-an-yang
added a commit
that referenced
this issue
May 9, 2023
hui-an-yang
added a commit
that referenced
this issue
May 9, 2023
hui-an-yang
added a commit
that referenced
this issue
May 10, 2023
…rorDetail BREAKING CHANGE: 1. In @taquito/rpc when validateContractAddress used to throw InvalidAddressError will now throw InvalidContractAddressError. 2. In @taquito/sapling prepareUnshieldedTransaction function when validateDestinationImplicitAddress used to throw InvalidAddressError now throw InvalidKeyHashError re #1994
hui-an-yang
added a commit
that referenced
this issue
May 10, 2023
hui-an-yang
added a commit
that referenced
this issue
May 11, 2023
hui-an-yang
added a commit
that referenced
this issue
May 11, 2023
hui-an-yang
added a commit
that referenced
this issue
May 11, 2023
hui-an-yang
added a commit
that referenced
this issue
May 11, 2023
hui-an-yang
added a commit
that referenced
this issue
May 11, 2023
hui-an-yang
added a commit
that referenced
this issue
May 11, 2023
9 tasks
hui-an-yang
added a commit
that referenced
this issue
May 12, 2023
* refactor: consolidate InvalidKeyError inot @taquito/core and improve across packages BREAKING CHANGE: Class SaplingToolkit function prepareUnshieldedTransaction used to throw InvalidKeyError now throw a InvalidAddressError instead re #1994 * refactor: consolidate InvalidPublicKey into @taquito/core and improve across packages re #1994 * refactor: consolidate InvalidSignatureError into @taquito/core and improve across packages re #1994 * refactor: minor update of the improved error classes re #1994 * refactor: consolidate InvalidcontractAddressError into @taquito/core and improve across packages re #1994 * refactor: consolidate InvalidChainIdError into @taquito/core and improve across packages re #1994 * refactor: consolidate InvalidKeyHashError into @taquito/core and improve across packages re #1994 * refactor: minor update for InvalidKeyHashError re #1994 * refactor: consolidate InvalidOperationHashError into @taquito/core and improve across packages re #1994 * refactor: consolidate InvalidOperationKindError into @taquito/core and improve across packages re #1994 * refactor: consolidate DeprecationError into @taquito/core re #1994 * refactor: consolidate ProhibitedActionError into @taquito/core re #1994 * refactor: imporve InvalidProtocolHashError and ValueConversionError in @taquito/utils re #1994 * refactor: added unit tests for error classes in @taquito/core re #1994 * refactor: consolidate ValidationResult into @taquito/core re #1994 * refactor: improve InvalidAddressError to show validation result in errorDetail BREAKING CHANGE: 1. In @taquito/rpc when validateContractAddress used to throw InvalidAddressError will now throw InvalidContractAddressError. 2. In @taquito/sapling prepareUnshieldedTransaction function when validateDestinationImplicitAddress used to throw InvalidAddressError now throw InvalidKeyHashError re #1994 * refactor: improve InvalidAddressError message format to be concise re #1994 * refactor: improve InvalidBlockHashError message format to be concise re #1994 * refactor: improve InvalidDerivationPathError message format to be consistent re #1994 * refactor: improve InvalidHexStringError message format re #1994 * refactor: improve InvalidMessageError message format re #1994 * refactor: improve InvalidViewParameterError message format re #1994 * refactor: improve InvalidKeyError message format re #1994 * refactor: improve teh rest of common error classes message format * refactor: replaced deprecated substr with substring across packages * refactor: moved validationResult back to @taquito/core
9 tasks
hui-an-yang
added a commit
that referenced
this issue
May 23, 2023
* 1992 create high level error categories (#2452) * build: created new package @taquito/core re #1992 * feat: added high-level error categories with unit tests re #1992 * build: new package-lock.json with @taquito-core for ci * build: updated a file name and adjusted build order * test: rename test file * chore: bump @taquito/core version to 16.1.2 * 1993 consolidating duplicate errors (#2463) * refactor: consolidated InvalidAddressError into @taquito/core re #1993 * refactor: consolidated InvalidBlockHashError into @taquito/core re #1993 * refactor: consolidated InvalidDerivationPathError into @taquito/core re #1993 * refactor: added InvalidDerivationPathError unit test in @taquito/core re #1993 * refactor: consolidated InvalidHexStringError in to @taquito/core and some style patches re #1993 * refactor: consolidated InvalidMessageError into @taquito/core re #1993 * refactor: consolidated InvalidViewParameterError into @taquito/core re #1993 * refactor: improve InvalidViewParameterError in @taquito/core re #1993 * refactor: removed tailling params destination/source in InvalidAddressError * 1994 @taquito utils error improvement (#2475) * refactor: consolidate InvalidKeyError inot @taquito/core and improve across packages BREAKING CHANGE: Class SaplingToolkit function prepareUnshieldedTransaction used to throw InvalidKeyError now throw a InvalidAddressError instead re #1994 * refactor: consolidate InvalidPublicKey into @taquito/core and improve across packages re #1994 * refactor: consolidate InvalidSignatureError into @taquito/core and improve across packages re #1994 * refactor: minor update of the improved error classes re #1994 * refactor: consolidate InvalidcontractAddressError into @taquito/core and improve across packages re #1994 * refactor: consolidate InvalidChainIdError into @taquito/core and improve across packages re #1994 * refactor: consolidate InvalidKeyHashError into @taquito/core and improve across packages re #1994 * refactor: minor update for InvalidKeyHashError re #1994 * refactor: consolidate InvalidOperationHashError into @taquito/core and improve across packages re #1994 * refactor: consolidate InvalidOperationKindError into @taquito/core and improve across packages re #1994 * refactor: consolidate DeprecationError into @taquito/core re #1994 * refactor: consolidate ProhibitedActionError into @taquito/core re #1994 * refactor: imporve InvalidProtocolHashError and ValueConversionError in @taquito/utils re #1994 * refactor: added unit tests for error classes in @taquito/core re #1994 * refactor: consolidate ValidationResult into @taquito/core re #1994 * refactor: improve InvalidAddressError to show validation result in errorDetail BREAKING CHANGE: 1. In @taquito/rpc when validateContractAddress used to throw InvalidAddressError will now throw InvalidContractAddressError. 2. In @taquito/sapling prepareUnshieldedTransaction function when validateDestinationImplicitAddress used to throw InvalidAddressError now throw InvalidKeyHashError re #1994 * refactor: improve InvalidAddressError message format to be concise re #1994 * refactor: improve InvalidBlockHashError message format to be concise re #1994 * refactor: improve InvalidDerivationPathError message format to be consistent re #1994 * refactor: improve InvalidHexStringError message format re #1994 * refactor: improve InvalidMessageError message format re #1994 * refactor: improve InvalidViewParameterError message format re #1994 * refactor: improve InvalidKeyError message format re #1994 * refactor: improve teh rest of common error classes message format * refactor: replaced deprecated substr with substring across packages * refactor: moved validationResult back to @taquito/core * refactor: addressed pr comments of wording and naming * 1994 taquito local forging error improvement (#2486) * refactor: update file name of error.ts to errors.ts for consistency * refactor: improve InvalidOperationSchemaError * refactor: improve OversizedEntryPointError * refactor: improve InvalidBallotValueError * refactor: improve DecodeBallotValueError * refactor: imrpove UnexpectedMichelsonValueError * refactor: improve OperationDecodingError * refactor: imporve OperationEncodingError * refactor: imrpove UnsupportedOperationError * refactor: improve DecodePvmKindError * refactor: improve InvalidSmartRollupAddressError * refactor: improve InvalidSmartRollupCommitmentHashError and DecodePvmKindError BREAKING CHANGE: 1. In @taquito/local-forging smartRollupAddressDecoder used to throw InvalidAddressError now throw invalidContractAddressErro 2. In @taquito/local-forging used to have class InvalidSmartRollupContractAddressError now is InvalidSmartRollupCommitmentHashError 3. In @taquito/local-forging function smartRollupContractAddressEncoder rename to smartRollupCommitmentHashEncoder * 1994 taquito signer error improvement (#2490) * refactor: imrpove InvalidMnemonicError * refactor: improve InvalidBitSize and InvalidCurveError * refactor: imporve InvalidSeedLengthError * refactor: replace PrivateKeyError with InvalidKeyError from @taquito/core and improve InvalidKeyErro BREAKING CHANGE: PrivateKeyError is replaced by common error InvalidKeyError from @taquito/core * refactor: imrpove ToBeImplemented * docs: added typedoc of InvalidSeedLengthError and ToBeImplemented * refactor: imporve InvalidPassphraseError * chore: updated pack-lock.json * fix: fix overlooked merge conflicts * chore: updated package-lock.json and keep bip39 v3.0.4
hui-an-yang
changed the title
Error improvements per packages
Error improvements per packages part1
May 24, 2023
9 tasks
created issue #2505 to continue the work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Error improvement for priority packages
Follow up of #160 as described in https://hackmd.io/@tca0T8LZT3au8LG6hSX20g/r1zTRTlfj_
Task 3 (should be split a least into one PR per package to ease the review): Go through all the errors in each package and:
The key "inva2obfVMEuPUnadAConLWk7Tf4Dt3n4svSgJwrgpamRqJXvaYcg1" is invalid. It contains the invalid prefix "inva", but "p2sk" was expected.
Surround the variable in the error message with quotes for clarity.Failed to encode value '[object Object]'
. Add tests to ensure proper rendering.errors.ts
file in the root of each package's /src folder. It will increase the ease of extending and maintaining error classes in the future.Here is an example of an error that needs improvement:
The text was updated successfully, but these errors were encountered: