refactor: added new error category class httpError

re #1994
ecadlabs · Jan 16, 2023 · 9d8da62 · 9d8da62
1 parent 641838f
commit 9d8da62
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 5 deletions.
diff --git a/packages/taquito-core/src/error/common.ts b/packages/taquito-core/src/error/common.ts
@@ -3,6 +3,7 @@ import {
   PermissionDeniedError,
   UnsupportedAction,
   InternalValidationError,
+  HttpError,
 } from './errors';
 import { STATUS_CODE } from '../constants/http_status_code';
 
@@ -195,7 +196,7 @@ export class ProhibitedActionError extends PermissionDeniedError {
  *  @param body Http request body
  *  @param url http request url
  */
-export class HttpResponseError extends Error {
+export class HttpResponseError extends HttpError {
   public name = 'HttpResponse';
 
   constructor(

diff --git a/packages/taquito-core/src/error/errors.ts b/packages/taquito-core/src/error/errors.ts
@@ -1,6 +1,6 @@
 /**
  *  @category Error
- *  @description Error that indicates the data get from other servies has incorrect format
+ *  @description Error that indicates invalid data being fetched from other services
  */
 export class InternalValidationError extends Error {
   public name = 'InternalValidationError';
@@ -71,7 +71,7 @@ export class NetworkError extends Error {
 
 /**
  *  @category Error
- *  @description Error that indicates
+ *  @description Error that permission deneied for a certain action
  */
 export class PermissionDeniedError extends Error {
   public name = 'PermissionDeniedError';
@@ -80,3 +80,15 @@ export class PermissionDeniedError extends Error {
     super(message);
   }
 }
+
+/**
+ *  @category Error
+ *  @description Error with Http services
+ */
+export class HttpError extends Error {
+  public name = 'HttpError';
+  public category = this.name;
+  constructor(public message: string) {
+    super(message);
+  }
+}
diff --git a/packages/taquito-http-utils/src/taquito-http-utils.ts b/packages/taquito-http-utils/src/taquito-http-utils.ts
@@ -5,7 +5,7 @@
 
 import { STATUS_CODE } from '@taquito/core';
 import axios, { AxiosAdapter } from 'axios';
-import { HttpResponseError, ParameterValidationError } from '@taquito/core';
+import { HttpResponseError, HttpError } from '@taquito/core';
 
 const isNode =
   typeof process !== 'undefined' && process.versions != null && process.versions.node != null;
@@ -39,7 +39,7 @@ export interface HttpRequestOptions {
  *  @category Error
  *  @description Error that indicates a general failure in making the HTTP request
  */
-export class HttpRequestFailed extends ParameterValidationError {
+export class HttpRequestFailed extends HttpError {
   public name = 'HttpRequestFailed';
 
   constructor(public message: string) {