refactor: improve InvalidViewParameterError message format

re #1994
ecadlabs · May 10, 2023 · f78a1bd · f78a1bd
1 parent c1987f3
commit f78a1bd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/taquito-core/src/errors.ts b/packages/taquito-core/src/errors.ts
@@ -119,9 +119,11 @@ export class InvalidViewParameterError extends ParameterValidationError {
   constructor(public viewName: string, public sigs: any, public args: any, public cause?: any) {
     super();
     this.name = 'InvalidViewParameterError';
-    this.message = `view name: ${viewName} received arguments: ${JSON.stringify(
+    this.message = `Invalid arguments ${JSON.stringify(
       args
-    )} while expecting one of the following signatures: (${JSON.stringify(sigs)}).`;
+    )} received for view name "${viewName}", expecting one of the following signatures: "${JSON.stringify(
+      sigs
+    )}".`;
   }
 }
 

diff --git a/packages/taquito-core/test/errors.spec.ts b/packages/taquito-core/test/errors.spec.ts
@@ -144,9 +144,9 @@ describe('common error classes', () => {
       expect(error).toBeInstanceOf(ParameterValidationError);
       expect(error).toBeInstanceOf(InvalidViewParameterError);
       expect(error.message).toEqual(
-        `view name: foo received arguments: "bar" while expecting one of the following signatures: (${JSON.stringify(
+        `Invalid arguments "bar" received for view name "foo", expecting one of the following signatures: "${JSON.stringify(
           { parameter: 'nat', result: 'nat' }
-        )}).`
+        )}".`
       );
     }
   });