Prepare monorepo import eapolinario flytepropeller #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
…atch (flyteorg#281) * FlytePropeller should ignore if Admin is already in terminal state Signed-off-by: Ketan Umare <[email protected]> * Lint fixes Signed-off-by: Ketan Umare <[email protected]>
* bump Signed-off-by: wild-endeavor <[email protected]> * tidy Signed-off-by: wild-endeavor <[email protected]>
… behavior consistent across (flyteorg#292)
… to keep behavior consistent across (flyteorg#292)" (flyteorg#293) This reverts commit 9ba5beb. Signed-off-by: Haytham Abuelfutuh <[email protected]>
…rentNodeID #minor (flyteorg#288) * Branch canexecute fix Signed-off-by: Ketan Umare <[email protected]> * tests Signed-off-by: Ketan Umare <[email protected]> * more unit test fixes Signed-off-by: Ketan Umare <[email protected]> * fixed tests Signed-off-by: Ketan Umare <[email protected]> * more documentation Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>
* Update code of conduct Signed-off-by: Samhita Alla <[email protected]> * boilerplate Signed-off-by: Samhita Alla <[email protected]>
* Revert "Construct subnode DataDir to be under parent's node OutputDir to keep behavior consistent across (flyteorg#292)" (flyteorg#293) This reverts commit 9ba5beb. Signed-off-by: Haytham Abuelfutuh <[email protected]> * Simplify GetNodeExecutionStatus Signed-off-by: Haytham Abuelfutuh <[email protected]> * SetDataDir in cached DynamicWorkflow case Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix case in which downstream nodes may incorrectly fail because of parentNodeID #minor (flyteorg#288) * Branch canexecute fix Signed-off-by: Ketan Umare <[email protected]> * tests Signed-off-by: Ketan Umare <[email protected]> * more unit test fixes Signed-off-by: Ketan Umare <[email protected]> * fixed tests Signed-off-by: Ketan Umare <[email protected]> * more documentation Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * [wip] Working for ev1 to be merged into flyteorg#294 (flyteorg#295) Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> * bump for DCO Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix DataDir of child nodes Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix mocks for tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * fixed unit test Signed-off-by: Ketan Umare <[email protected]> Co-authored-by: Ketan Umare <[email protected]> Co-authored-by: Ketan Umare <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
* Upgrade flyteplugins to v0.5.67 Signed-off-by: Jeev B <[email protected]> * Tidy up unused versions Signed-off-by: Jeev B <[email protected]>
…roup (flyteorg#306) * Fix pod creation issue when having multiple secret from same secret group Signed-off-by: Pradithya Aria <[email protected]> * Add new line Signed-off-by: Pradithya Aria <[email protected]> * Remove garbage Signed-off-by: Pradithya Aria <[email protected]>
* bump flytestdlib version Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Jeev B <[email protected]>
…#318) Signed-off-by: Daniel Rammer <[email protected]>
…g#321) * Revert "Adopt flyteidl's ordered variable map change (flyteorg#305)" This reverts commit 23f809c. Signed-off-by: Sean Lin <[email protected]>
* Use correct k8 client Signed-off-by: Sonja Ericsson <[email protected]> * Use correct k8 client Signed-off-by: Sonja Ericsson <[email protected]> --------- Signed-off-by: Sonja Ericsson <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Bernhard Stadlbauer <[email protected]>
* not stripping structure from literal types Signed-off-by: Daniel Rammer <[email protected]> * fixed new lint issues Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Bernhard Stadlbauer <[email protected]>
…teorg#574) * correctly checking error code Signed-off-by: Daniel Rammer <[email protected]> * fixed lint issue Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
* Use GetExecutionData instead Signed-off-by: Haytham Abuelfutuh <[email protected]> * bump Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * more fixes Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix more Signed-off-by: Haytham Abuelfutuh <[email protected]> * Regenerate Signed-off-by: Haytham Abuelfutuh <[email protected]> * Only call GetExecutionData when the workflow succeeds Signed-off-by: Haytham Abuelfutuh <[email protected]> --------- Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
* Support for cross-project secrets for GCP Signed-off-by: Jeev B <[email protected]> * Bump flyteplugins version (flyteorg#581) Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Jeev B <[email protected]> --------- Signed-off-by: Jeev B <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]>
* Update `flyteplugins` Signed-off-by: Bernhard Stadlbauer <[email protected]> * Update `flytepropeller` Signed-off-by: Bernhard Stadlbauer <[email protected]> * Fix imports Signed-off-by: Bernhard Stadlbauer <[email protected]> * Bump flyteplugins to v1.1.7 Signed-off-by: Bernhard Stadlbauer <[email protected]> * Return `err` instead of `nil` Signed-off-by: Bernhard Stadlbauer <[email protected]> --------- Signed-off-by: Bernhard Stadlbauer <[email protected]> Co-authored-by: Dan Rammer <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
* added IsFailurePermanent flag on DynamicTaskStatus Signed-off-by: Daniel Rammer <[email protected]> * fixed linter Signed-off-by: Daniel Rammer <[email protected]> * cleaned up retryable vs permanent reporting Signed-off-by: Daniel Rammer <[email protected]> * make generate Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: eapolinario <[email protected]>
* fixing max parallelism Signed-off-by: Daniel Rammer <[email protected]> * Run subset of functional tests Signed-off-by: eduardo apolinario <[email protected]> * Comment basics.deck.wf test out Signed-off-by: eduardo apolinario <[email protected]> * Use flytetools@master in e2e tests and bring decks test back Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
* updated flytestdlib Signed-off-by: Daniel Rammer <[email protected]> * fixing unit tests - using log events rather than unavailable admin Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
* updated flyteidl to local to get ArrayNode Signed-off-by: Daniel Rammer <[email protected]> * added boilerplate to support ArrayNode Signed-off-by: Daniel Rammer <[email protected]> * pushing forward Signed-off-by: Daniel Rammer <[email protected]> * refactored node executor interfaces to fix dependency cycle Signed-off-by: Daniel Rammer <[email protected]> * refactoring almost complete Signed-off-by: Daniel Rammer <[email protected]> * refactor complete Signed-off-by: Daniel Rammer <[email protected]> * supporting environment variables Signed-off-by: Daniel Rammer <[email protected]> * minimum viable product Signed-off-by: Daniel Rammer <[email protected]> * update print statements for debugging Signed-off-by: Daniel Rammer <[email protected]> * massive refactor fixing NodeExecutionContext override for ArrayNode Signed-off-by: Daniel Rammer <[email protected]> * refactoring TODOs Signed-off-by: Daniel Rammer <[email protected]> * subnode retries working Signed-off-by: Daniel Rammer <[email protected]> * parallelism working Signed-off-by: Daniel Rammer <[email protected]> * cache and cache_serialize working - first new functionality in maptask Signed-off-by: Daniel Rammer <[email protected]> * adding implementation notes Signed-off-by: Daniel Rammer <[email protected]> * removed eventing from subtasks Signed-off-by: Daniel Rammer <[email protected]> * adding correct requirements Signed-off-by: Daniel Rammer <[email protected]> * working end-2-end with flytekit Signed-off-by: Daniel Rammer <[email protected]> * reporting output directory on success Signed-off-by: Daniel Rammer <[email protected]> * fixed output directory append Signed-off-by: Daniel Rammer <[email protected]> * mocking TaskTemplate interface to enable caching Signed-off-by: Daniel Rammer <[email protected]> * capture failure reasons Signed-off-by: Daniel Rammer <[email protected]> * wrapped up abort and finalize functionality Signed-off-by: Daniel Rammer <[email protected]> * mocking initialization events Signed-off-by: Daniel Rammer <[email protected]> * sending all events Signed-off-by: Daniel Rammer <[email protected]> * minor refactoring of debug prints and formatting Signed-off-by: Daniel Rammer <[email protected]> * intratask checkpointing working Signed-off-by: Daniel Rammer <[email protected]> * support for and Signed-off-by: Daniel Rammer <[email protected]> * setting node log ids correctly Signed-off-by: Daniel Rammer <[email protected]> * reporting cache status Signed-off-by: Daniel Rammer <[email protected]> * correctly setting subnode abort phase Signed-off-by: Daniel Rammer <[email protected]> * removing dead code Signed-off-by: Daniel Rammer <[email protected]> * cleaned up most random TODO items Signed-off-by: Daniel Rammer <[email protected]> * refactored into new files Signed-off-by: Daniel Rammer <[email protected]> * refactoring for ArrayNode unit tests Signed-off-by: Daniel Rammer <[email protected]> * refactored for unit testing to allow creation of NodeExecutor in array package Signed-off-by: Daniel Rammer <[email protected]> * first unit test for handling ArrayNodePhaseNone Signed-off-by: Daniel Rammer <[email protected]> * most of executing unit tests completed Signed-off-by: Daniel Rammer <[email protected]> * finished executing unit tests Signed-off-by: Daniel Rammer <[email protected]> * finished succeeding unit tests Signed-off-by: Daniel Rammer <[email protected]> * wrote failing phase unit tests Signed-off-by: Daniel Rammer <[email protected]> * moving towards complete unit_test success Signed-off-by: Daniel Rammer <[email protected]> * unit tests passing Signed-off-by: Daniel Rammer <[email protected]> * fixed lint issues Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl dep Signed-off-by: Daniel Rammer <[email protected]> * added unit tests for Abort Signed-off-by: Daniel Rammer <[email protected]> * adding unit test for Finalize Signed-off-by: Daniel Rammer <[email protected]> * added utils unit tests Signed-off-by: Daniel Rammer <[email protected]> * moved state structs to handler package Signed-off-by: Daniel Rammer <[email protected]> * added docs Signed-off-by: Daniel Rammer <[email protected]> * cleaned up abort event reporting Signed-off-by: Daniel Rammer <[email protected]> * fixed RecordNodeEvent unit tests Signed-off-by: Daniel Rammer <[email protected]> * removed taskEventRecorder from nodes package Signed-off-by: Daniel Rammer <[email protected]> * adding interface checking for arraynode Signed-off-by: Daniel Rammer <[email protected]> * added transform unit test Signed-off-by: Daniel Rammer <[email protected]> * fixed input bindings issue Signed-off-by: Daniel Rammer <[email protected]> * fixed unit tests Signed-off-by: Daniel Rammer <[email protected]> * fixed unit tests Signed-off-by: Daniel Rammer <[email protected]> * go generate Signed-off-by: Daniel Rammer <[email protected]> * addressing random TODO Signed-off-by: Daniel Rammer <[email protected]> * fixed unit tests Signed-off-by: Daniel Rammer <[email protected]> * addressing pr comments Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
* go mod Signed-off-by: Gopal K. Vashishtha <[email protected]> * updating go mod Signed-off-by: Gopal K. Vashishtha <[email protected]> * bumping version Signed-off-by: Gopal K. Vashishtha <[email protected]> * some commenting Signed-off-by: Gopal K. Vashishtha <[email protected]> * make singular unions castable to their underlying type (flyteorg#599) Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Gopal K. Vashishtha <[email protected]> * fixed correct propagation of launchplan start error (flyteorg#598) Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Gopal K. Vashishtha <[email protected]> * bumping flytestdlib Signed-off-by: Gopal K. Vashishtha <[email protected]> --------- Signed-off-by: Gopal K. Vashishtha <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Co-authored-by: Dan Rammer <[email protected]>
Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
* Bump flyteplugins to 1.1.15 Signed-off-by: Eduardo Apolinario <[email protected]> * Drop replace directive from go.mod Signed-off-by: Eduardo Apolinario <[email protected]> * go mod tidy Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Describe your changes
Check all the applicable boxes
Screenshots
Note to reviewers