Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] InvalidImageName errors are not reported correctly #306

Closed
3 of 20 tasks
katrogan opened this issue May 8, 2020 · 4 comments
Closed
3 of 20 tasks

[BUG] InvalidImageName errors are not reported correctly #306

katrogan opened this issue May 8, 2020 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@katrogan
Copy link
Contributor

katrogan commented May 8, 2020

Describe the bug
InvalidImageName errors are not reported in the UI leading to confusion when tasks are stuck pending without logs or other debug information.

Expected behavior
The UI should indicate a task failed because of InvalidImageName

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
This is very similar to #244

@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels May 8, 2020
@kumare3
Copy link
Contributor

kumare3 commented Jun 10, 2020

@katrogan we do show ImagePullBackoff failures. Is this not enough? Can we please close this bug, if this solves the issue?

@katrogan
Copy link
Contributor Author

@kumare3 i observed this while on-call after your ImagePullBackoff change was merged

@kumare3
Copy link
Contributor

kumare3 commented Jun 11, 2020

An example would be great

@katrogan
Copy link
Contributor Author

  Warning  Failed         7m29s (x5053 over 18h)  kubelet, ip-10-44-163-228.ec2.internal  Error: InvalidImageName
  Warning  InspectFailed  2m33s (x5077 over 18h)  kubelet, ip-10-44-163-228.ec2.internal  Failed to apply default image tag "12345.dkr.ecr.us-east-1.amazonaws.com/repo:flyte.{{ salt['environ.get']('IMAGE_VERSION') }}": couldn't parse image reference "12345.dkr.ecr.us-east-1.amazonaws.com/repo:flyte.{{ salt['environ.get']('IMAGE_VERSION') }}": invalid reference format```

@EngHabu EngHabu added this to the 0.18.0 milestone Aug 31, 2021
@pingsutw pingsutw self-assigned this Sep 10, 2021
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Sep 20, 2021
@EngHabu EngHabu closed this as completed Oct 6, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
…roup (flyteorg#306)

* Fix pod creation issue when having multiple secret from same secret group

Signed-off-by: Pradithya Aria <[email protected]>

* Add new line

Signed-off-by: Pradithya Aria <[email protected]>

* Remove garbage

Signed-off-by: Pradithya Aria <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
…eorg#306)

* Removed retries during precheck and falling back on k8s retries

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Linter fixes

Signed-off-by: Prafulla Mahindrakar <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* modify flytefile doc

Signed-off-by: Samhita Alla <[email protected]>

* add download() method

Signed-off-by: Samhita Alla <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.17.1 to 1.27.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.17.1...v1.27.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* Using sandbox-lite

Signed-off-by: Kevin Su <[email protected]>

* Add demo command

Signed-off-by: Kevin Su <[email protected]>

* wip

Signed-off-by: Kevin Su <[email protected]>

* wip

Signed-off-by: Kevin Su <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
* Correct aws batch job state

Signed-off-by: Kevin Su <[email protected]>

* Add env FAST_ON_ERROR to aws batch job

Signed-off-by: Kevin Su <[email protected]>

* Add tests

Signed-off-by: Kevin Su <[email protected]>

* update tests

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

* update test

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
…roup (flyteorg#306)

* Fix pod creation issue when having multiple secret from same secret group

Signed-off-by: Pradithya Aria <[email protected]>

* Add new line

Signed-off-by: Pradithya Aria <[email protected]>

* Remove garbage

Signed-off-by: Pradithya Aria <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
…eorg#306)

* Removed retries during precheck and falling back on k8s retries

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Linter fixes

Signed-off-by: Prafulla Mahindrakar <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
* Correct aws batch job state

Signed-off-by: Kevin Su <[email protected]>

* Add env FAST_ON_ERROR to aws batch job

Signed-off-by: Kevin Su <[email protected]>

* Add tests

Signed-off-by: Kevin Su <[email protected]>

* update tests

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

* update test

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
* Using sandbox-lite

Signed-off-by: Kevin Su <[email protected]>

* Add demo command

Signed-off-by: Kevin Su <[email protected]>

* wip

Signed-off-by: Kevin Su <[email protected]>

* wip

Signed-off-by: Kevin Su <[email protected]>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
* Using sandbox-lite

Signed-off-by: Kevin Su <[email protected]>

* Add demo command

Signed-off-by: Kevin Su <[email protected]>

* wip

Signed-off-by: Kevin Su <[email protected]>

* wip

Signed-off-by: Kevin Su <[email protected]>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
* Using sandbox-lite

Signed-off-by: Kevin Su <[email protected]>

* Add demo command

Signed-off-by: Kevin Su <[email protected]>

* wip

Signed-off-by: Kevin Su <[email protected]>

* wip

Signed-off-by: Kevin Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants