Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Flyteadmin single task execution request validation #567

Closed
4 of 20 tasks
katrogan opened this issue Oct 24, 2020 · 0 comments
Closed
4 of 20 tasks

[BUG] Flyteadmin single task execution request validation #567

katrogan opened this issue Oct 24, 2020 · 0 comments
Assignees
@katrogan
Labels
bug Something isn't working
Milestone
0.10.0

Comments

@katrogan
Copy link
Contributor

Describe the bug
Single task execution create requests require different parameters than conventional create execution requests. Specifically overrides in traditional requests are actually required parameters in the single task case.

Expected behavior
The role field should be required when creating a single task execution. Furthermore the labels and annotations should be passed to the created execution.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. ...
  2. ...

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
This will affect single task executions launched from the UI (which currently doesn't prompt the user for a role) cc @schottra
@katrogan katrogan added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers and removed untriaged This issues has not yet been looked at by the Maintainers labels Oct 24, 2020
@katrogan katrogan self-assigned this Oct 24, 2020
@katrogan katrogan added this to the 0.10.0 milestone Oct 24, 2020
@katrogan katrogan mentioned this issue Nov 13, 2020
Merged
8 tasks
@katrogan katrogan reopened this Nov 14, 2020
@rahul-theorem rahul-theorem mentioned this issue Sep 4, 2022
Closed
2 tasks
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@pmahindrakar-oss
Update startedAt timestamp only if not set (flyteorg#567)
7915ae8 
* Update startedAt timestamp only if not set

Signed-off-by: pmahindrakar-oss <[email protected]>

* sort imports

Signed-off-by: pmahindrakar-oss <[email protected]>

---------

Signed-off-by: pmahindrakar-oss <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
Added IsFailurePermanent flag on DynamicTaskStatus (flyteorg#567)
0cfb0a0 
* added IsFailurePermanent flag on DynamicTaskStatus

Signed-off-by: Daniel Rammer <[email protected]>

* fixed linter

Signed-off-by: Daniel Rammer <[email protected]>

* cleaned up retryable vs permanent reporting

Signed-off-by: Daniel Rammer <[email protected]>

* make generate

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@hamersaw
Added IsFailurePermanent flag on DynamicTaskStatus (flyteorg#567)
7010392 
* added IsFailurePermanent flag on DynamicTaskStatus

Signed-off-by: Daniel Rammer <[email protected]>

* fixed linter

Signed-off-by: Daniel Rammer <[email protected]>

* cleaned up retryable vs permanent reporting

Signed-off-by: Daniel Rammer <[email protected]>

* make generate

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@pmahindrakar-oss
Update startedAt timestamp only if not set (flyteorg#567)
ca0ebf1 
* Update startedAt timestamp only if not set

Signed-off-by: pmahindrakar-oss <[email protected]>

* sort imports

Signed-off-by: pmahindrakar-oss <[email protected]>

---------

Signed-off-by: pmahindrakar-oss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrogan katrogan

Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@katrogan