Dead Ending Microsoft.CSharp Package and Bumping the leftout assembly versions to 5.0.0.0 #2264

Anipik · 2020-01-28T00:56:26Z

@333fred @cston @jaredpar just to check if you guys are okay with the no longer producing the Microsoft.CSharp package.

Fixes #1918

jkoritzinsky

Looks good from my end (S.R.CS.U)

jaredpar · 2020-01-28T05:59:42Z

@333fred @cston @jaredpar just to check if you guys are okay with the no longer producing the Microsoft.CSharp package.

What are the implications of doing this? Also do we still produce the Microsoft.VisualBasic package. That is the VB equivalent of Microsoft.CSharp. I would be suspicious if we're in a state where we're producing one but not the other.

joperezr · 2020-01-28T17:07:55Z

What are the implications of doing this? Also do we still produce the Microsoft.VisualBasic package. That is the VB equivalent of Microsoft.CSharp. I would be suspicious if we're in a state where we're producing one but not the other.

No real implications other than having Microsoft.CSharp's only shipping mechanism being via the shared framework. Usually we try to keep OOBs shipping as package in case we want to add API to it after a release, but with Microsoft.CSharp we can't really do that because it is inbox in many places. The only real way to ship new API via a package for Microsoft.CSharp would be to have it target netcoreapp5.0 (since it targets netstandard2.0 today) and add the API to Netcoreapp 5.0 build only. Because we don't have any plans to do that (and even if we did, we can just do that directly on the shared framework) the best thing is just to stop building the package. M.Vb package was removed about a year ago via this PR: dotnet/corefx#34087

ViktorHofer

@ericstj it probably doesn't matter much but should we change the configuration to netcoreapp (latest), away from netstandard2.0?

ericstj · 2020-01-28T17:14:40Z

Agree with @ViktorHofer let's retarget this to netcoreapp5.0 and clean up the configurations.

ericstj · 2020-01-28T17:16:25Z

...braries/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.il

@@ -41,7 +41,7 @@
    01 00 00 00 00
  ) // false
  .hash algorithm 0x00008004
-  .ver 4:0:5:0
+  .ver 5:0:0:0


Separate issue. We should see about setting define's to flow the actual values from the build-system. That way we get real fileversion and assembly version in ILProj-built assemblies.

ericstj

Please re-target. While you are at it, you can clean up

runtime/src/libraries/pkg/descriptions.json

Lines 17 to 27 in 4f9ae42

    
           { 
        
             "Name": "Microsoft.CSharp", 
        
             "Description": "Provides support for compilation and code generation, including dynamic, using the C# language.", 
        
             "CommonTypes": [ 
        
               "Microsoft.CSharp.RuntimeBinder.Binder", 
        
               "Microsoft.CSharp.RuntimeBinder.RuntimeBinderException", 
        
               "Microsoft.CSharp.RuntimeBinder.CSharpArgumentInfo", 
        
               "Microsoft.CSharp.RuntimeBinder.CSharpArgumentInfoFlags", 
        
               "Microsoft.CSharp.RuntimeBinder.CSharpBinderFlags" 
        
             ] 
        
           },

joperezr · 2020-01-28T17:26:17Z

While you are at it, you can clean up

Can we also clean the BaselineVersion of the package index for Microsoft.CSharp:

runtime/src/libraries/pkg/Microsoft.Private.PackageBaseline/packageIndex.json

Line 86 in 2cf4433

"BaselineVersion": "5.0.0",

joperezr

LGTM other than re-targetting and cleanup.

jaredpar · 2020-01-28T17:40:43Z

@joperezr thanks for the explanation. That all makes sense.

What about my questions about Microsoft.VisualBasic though? After reading your explanation I feel more strongly that Microsoft.CSharp and Microsoft.VisualBasic should be consistent here.

joperezr · 2020-01-28T18:14:17Z

I probably shouldn't have used abbreviations for that part of my response above 😄

M.Vb package was removed about a year ago via this PR: dotnet/corefx#34087

M.Vb I meant Microsoft.VisualBasic, so that package has been removed from our build for one year now. I'm not sure why at that time we didn't decide to also remove Microsoft.CSharp package, since I agree with you that these two should always be somewhat consistent.

jaredpar · 2020-01-28T18:53:01Z

@joperezr

M.Vb I meant Microsoft.VisualBasic, so that package has been removed from our build for one year now.

Great! This all seem good to me.

jaredpar

Approving the stopping of publishing Microsoft.CSharp as a package. Have not looked specifically at the changes involved here.

ericstj · 2020-01-29T01:09:09Z

Test failure is due to inbox assembly version change. Requires temporary suppression here:
https://github.com/dotnet/runtime/blob/master/src/libraries/pkg/test/frameworkSettings/netcoreapp5.0/settings.targets

Add IgnoredReference for System.Runtime.CompilerServices.Unsafe.

ghost · 2020-01-29T06:26:11Z

Hello @Anipik!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

jkotas · 2020-01-29T16:49:55Z

This is causing majority of PRs to fail with:

Unhandled exception. System.IO.FileLoadException: Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The located assembly's manifest definition does not match the assembly reference. (0x80131040 (FUSION_E_REF_DEF_MISMATCH))\nFile name: 'System.Runtime.CompilerServices.Unsafe, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'\n at

I am going to submit a revert.

ericstj · 2020-01-29T16:51:54Z

That's interesting seems like a bug in the live-live build. We should figure out what part of the stack is not running on live bits.

…assembly versions to 5.0.0.0 (#2264)" (#2344) This reverts commit 5fca041.

…mpilerServices.Unsafe (#2354) * Dead Ending Microsoft.CSharp Package and Bumping the leftout assembly versions to 5.0.0.0 (#2264) * deadending Microsoft.Csharp Package and bumping the assembly versions * retargeting and clean up * Update Microsoft.CSharp.csproj * fixing the build * reference -> projectreference * adding ignored reference * removing package references and making R2rDump bin place to a specifc output directory * remove package reference from R2r dump as well * adding comment and targeting netstandard2.0 * adding back package references for netstandard lib build * adding back baseline version for consistency

deadending Microsoft.Csharp Package and bumping the assembly versions

de5eb34

Anipik requested review from jkoritzinsky, ViktorHofer, ericstj and joperezr January 28, 2020 00:56

Dotnet-GitSync-Bot added the area-Microsoft.CSharp label Jan 28, 2020

Anipik mentioned this pull request Jan 28, 2020

Fix S.R.CS.U and Microsoft.CSharp assembly version downgrade from 3.1->5.0 #2180

Closed

jkoritzinsky approved these changes Jan 28, 2020

View reviewed changes

ViktorHofer approved these changes Jan 28, 2020

View reviewed changes

ericstj reviewed Jan 28, 2020

View reviewed changes

ericstj approved these changes Jan 28, 2020

View reviewed changes

joperezr approved these changes Jan 28, 2020

View reviewed changes

retargeting and clean up

c86df57

Anipik added 2 commits January 28, 2020 09:49

Merge branch 'master' into FixAssemblVersions

dfbccf1

Update Microsoft.CSharp.csproj

9a4b0f1

fixing the build

5276422

jaredpar approved these changes Jan 28, 2020

View reviewed changes

reference -> projectreference

51440fb

ericstj approved these changes Jan 29, 2020

View reviewed changes

adding ignored reference

f64ab6c

Anipik added the auto-merge label Jan 29, 2020

Anipik merged commit 5fca041 into dotnet:master Jan 29, 2020

Anipik deleted the FixAssemblVersions branch January 29, 2020 06:37

jkoritzinsky mentioned this pull request Jan 29, 2020

Official build break in publish stage: NuGet library mismatch vs. SDK #2319

Closed

jaredpar pushed a commit that referenced this pull request Jan 29, 2020

Revert "Dead Ending Microsoft.CSharp Package and Bumping the leftout …

89045e5

…assembly versions to 5.0.0.0 (#2264)" (#2344) This reverts commit 5fca041.

ghost locked as resolved and limited conversation to collaborators Dec 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dead Ending Microsoft.CSharp Package and Bumping the leftout assembly versions to 5.0.0.0 #2264

Dead Ending Microsoft.CSharp Package and Bumping the leftout assembly versions to 5.0.0.0 #2264

Anipik commented Jan 28, 2020

jkoritzinsky left a comment

jaredpar commented Jan 28, 2020

joperezr commented Jan 28, 2020

ViktorHofer left a comment

ericstj commented Jan 28, 2020

ericstj Jan 28, 2020

ericstj left a comment

joperezr commented Jan 28, 2020

joperezr left a comment

jaredpar commented Jan 28, 2020

joperezr commented Jan 28, 2020 •

edited

Loading

jaredpar commented Jan 28, 2020

jaredpar left a comment

ericstj commented Jan 29, 2020

ghost commented Jan 29, 2020

jkotas commented Jan 29, 2020

ericstj commented Jan 29, 2020

	{
	"Name": "Microsoft.CSharp",
	"Description": "Provides support for compilation and code generation, including dynamic, using the C# language.",
	"CommonTypes": [
	"Microsoft.CSharp.RuntimeBinder.Binder",
	"Microsoft.CSharp.RuntimeBinder.RuntimeBinderException",
	"Microsoft.CSharp.RuntimeBinder.CSharpArgumentInfo",
	"Microsoft.CSharp.RuntimeBinder.CSharpArgumentInfoFlags",
	"Microsoft.CSharp.RuntimeBinder.CSharpBinderFlags"
	]
	},

Dead Ending Microsoft.CSharp Package and Bumping the leftout assembly versions to 5.0.0.0 #2264

Dead Ending Microsoft.CSharp Package and Bumping the leftout assembly versions to 5.0.0.0 #2264

Conversation

Anipik commented Jan 28, 2020

jkoritzinsky left a comment

Choose a reason for hiding this comment

jaredpar commented Jan 28, 2020

joperezr commented Jan 28, 2020

ViktorHofer left a comment

Choose a reason for hiding this comment

ericstj commented Jan 28, 2020

ericstj Jan 28, 2020

Choose a reason for hiding this comment

ericstj left a comment

Choose a reason for hiding this comment

joperezr commented Jan 28, 2020

joperezr left a comment

Choose a reason for hiding this comment

jaredpar commented Jan 28, 2020

joperezr commented Jan 28, 2020 • edited Loading

jaredpar commented Jan 28, 2020

jaredpar left a comment

Choose a reason for hiding this comment

ericstj commented Jan 29, 2020

ghost commented Jan 29, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

jkotas commented Jan 29, 2020

ericstj commented Jan 29, 2020

joperezr commented Jan 28, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.