Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Dead Ending Microsoft.CSharp Package and Bumping the leftout assembly versions to 5.0.0.0 (#2264)" #2344

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Revert "Dead Ending Microsoft.CSharp Package and Bumping the leftout assembly versions to 5.0.0.0 (#2264)" #2344

merged 1 commit into from
Jan 29, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jan 29, 2020

This reverts commit 5fca041.

@jkotas
Revert "Dead Ending Microsoft.CSharp Package and Bumping the leftout …
a3e9980 
…assembly versions to 5.0.0.0 (#2264)"

This reverts commit 5fca041.
@jkotas
Copy link
Member Author

jkotas commented Jan 29, 2020 •
edited
Loading

This is fixing:

Unhandled exception. System.IO.FileLoadException: Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The located assembly's manifest definition does not match the assembly reference. (0x80131040 (FUSION_E_REF_DEF_MISMATCH))\nFile name: 'System.Runtime.CompilerServices.Unsafe, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

that majority of PRs are failing with now.

cc @Anipik

@jkotas jkotas mentioned this pull request Jan 29, 2020
Closed
@jaredpar
Copy link
Member

Using Admin to merge this change. Everything is already in a broken state and this should be taking us out of it.

@jaredpar jaredpar merged commit 89045e5 into dotnet:master Jan 29, 2020
ViktorHofer
ViktorHofer reviewed Jan 29, 2020
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ViktorHofer
Copy link
Member

cc @Anipik

@ViktorHofer
Copy link
Member

Using Admin to merge this change. Everything is already in a broken state and this should be taking us out of it.

Why would you need admin permissions to merge the approved change?

@jaredpar
Copy link
Member

Why would you need admin permissions to merge the approved change?

It wasn't actually necessary here. I'm used to Roslyn where we have more required status checks. Hence merging before tests run can only be done with admin. The message I posted is just my standard "i'm about to do something outside recommended guidelines"

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@jaredpar jaredpar jaredpar approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkotas @jaredpar @ViktorHofer @Dotnet-GitSync-Bot