Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S.R.CS.U and Microsoft.CSharp assembly version downgrade from 3.1->5.0 #2180

Conversation

jkoritzinsky
Copy link
Member

Allow the System.Runtime.CompilerServices.Unsafe and the runtime Microsoft.CSharp assembly versions to match the defaults (in this case 5.0.0).

Fixes #1918

…osoft.CSharp assembly versions to match the defaults.
…e assembly version isn't injected by the IL SDK during build.
@ghost
Copy link

ghost commented Jan 27, 2020

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Anipik
Copy link
Contributor

Anipik commented Jan 28, 2020

@jkoritzinsky i opened a new one pr to fix this #2264 as it required some more fixes.

@jkoritzinsky
Copy link
Member Author

Superseded by #2264.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
@jkoritzinsky jkoritzinsky deleted the fix-S.R.CS.U-and-M.CSharp-assembly-versions branch January 21, 2021 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants