Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official build break in publish stage: NuGet library mismatch vs. SDK #2319

Closed
dagood opened this issue Jan 29, 2020 · 7 comments
Closed

Official build break in publish stage: NuGet library mismatch vs. SDK #2319

dagood opened this issue Jan 29, 2020 · 7 comments

Comments

@dagood
Copy link
Member

dagood commented Jan 29, 2020

First repro: https://dev.azure.com/dnceng/internal/_build/results?buildId=499590&view=results

D:\a\1\s.packages\microsoft.dotnet.arcade.sdk\5.0.0-beta.20071.3\tools\SdkTasks\PublishArtifactsInManifest.proj(65,5): error : Method not found: 'NuGet.Versioning.NuGetVersion NuGet.Packaging.Core.PackageIdentity.get_Version()'.

This is a common class of issue where the Arcade SDK is built against a certain NuGet version, but the SDK contains another that is incompatible when used at runtime. We recently updated the SDK, triggering it.

We need to update the Arcade SDK to take this fix: dotnet/arcade#1965

"Microsoft.DotNet.Arcade.Sdk": "5.0.0-beta.20071.3",

We need at least 5.0.0-beta.20074.6.

@jkoritzinsky
Copy link
Member

Our maestro PR is currently blocked on something. It looks like it might be linker issues. #2074

@jkoritzinsky jkoritzinsky removed the untriaged New issue has not been triaged by the area owner label Jan 29, 2020
@dagood
Copy link
Member Author

dagood commented Jan 29, 2020

Alternative: downgrade the SDK. (Optionally, disable restoring internal tools to also remove flakiness.)

@dagood
Copy link
Member Author

dagood commented Jan 29, 2020

FYI @dotnet/runtime-infrastructure

@safern
Copy link
Member

safern commented Jan 29, 2020

(Optionally, disable restoring internal tools to also remove flakiness.)

I just merged a PR which should hopefully help with that.

@jkoritzinsky
Copy link
Member

I’d rather not downgrade the SDK since to unblock #2115 and dotnet/sdk#3884 I need to update to an SDK with #2264 once that’s published (which would be after we fix this, but would lead us back to the same problem very quickly).

I think we should either update our dotnet/arcade subscription or back out the linker upgrade from the Maestro PR until the blocking issue is fixed.

@ViktorHofer
Copy link
Member

I just removed the linker update (again) and disabled the subscription (again) to get the Arcade update in. @marek-safar is following-up on the break illink.

#2074

@dagood
Copy link
Member Author

dagood commented Jan 31, 2020

Thanks all, new build is green: https://dev.azure.com/dnceng/internal/_build/results?buildId=502394&view=results. 🎉

@dagood dagood closed this as completed Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants