Add egress extensibility, refactor built-in egress providers, and extension packaging #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add configuration section for Egress Extensibility Related #1635
Take FI into `feature/egressExtension`
* Add azure blob storage extension project * More temp changes for getting azure-storage to compile * Fix issues after rebasing on recent changes from main * Add encapsulated strings class to new assembly * Update PR feedback
Co-authored-by: Justin Anderson <[email protected]>
…kkeirstead/egressExtensionUpdated
…m/kkeirstead/dotnet-monitor into kkeirstead/egressExtensionUpdated
…dated Merging main into feature/egressExtension
Merge Main into feature/egressExtension
… has successfully transferred (and egressed) metadata for the AzureBlobStorage extension. Needs cleanup and potentially additions to the testing.
…' of https://github.com/kkeirstead/dotnet-monitor into kkeirstead/egressExtension_EnableNonStringConfiguration
…feature/egressExtension
…sConfigurationProvider (#4114)
jander-msft
added
the
update-release-notes
ghost
added
the
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/Microsoft.Diagnostics.Monitoring.Options/ExtensionEgressProviderOptions.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Apr 4, 2023
wiktork
reviewed
Apr 4, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressHelper.cs
Show resolved
Hide resolved
wiktork
reviewed
Apr 4, 2023
src/Extensions/Microsoft.Diagnostics.Monitoring.Extension.Common/EgressException.cs
Show resolved
Hide resolved
wiktork
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the AzureBlobStorage and S3Storage egress providers into separate executables as egress extensions using an extensibility surface that allows others to write their own egress providers that can be configured for use with dotnet-monitor. The .NET Tool package remains functionally unchanged (it includes both egress extensions) whereas the product archive no longer contains the egress extension binaries; consumers will have to layer the egress extension archives on top of the product archive.
Release Notes Entry
Refactor AzureBlobStorage and S3Storage egress into extensions