Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Egress Extensibility] Fix Logging Verbosity Propagation #4136

Merged
merged 7 commits into from
Apr 4, 2023
Merged

[Egress Extensibility] Fix Logging Verbosity Propagation #4136

merged 7 commits into from
Apr 4, 2023

Conversation

kkeirstead
Copy link
Member

Summary

Currently, extensions aren't respecting dotnet-monitor's configured LogLevel verbosity. This could result in a user asking for Debug level logs, receiving them from dotnet-monitor, but only receiving Information from an extension. This change propagates the LogLevel from dotnet-monitor to the extension.

Release Notes Entry

@kkeirstead kkeirstead requested a review from a team as a code owner April 3, 2023 17:25
@ghost ghost added the needs-review label Apr 3, 2023
@ghost ghost removed the needs-review label Apr 3, 2023
@ghost ghost added needs-review and removed needs-review labels Apr 3, 2023
@ghost ghost added the needs-review label Apr 4, 2023
@ghost ghost removed the needs-review label Apr 4, 2023
@kkeirstead kkeirstead merged commit ef2d49b into dotnet:feature/egressExtension Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jander-msft jander-msft jander-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkeirstead @jander-msft