-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to feature/egressExtension
Part 1
#2759
Merged
kkeirstead
merged 65 commits into
dotnet:feature/egressExtension
from
kkeirstead:kkeirstead/egressExtensionP1_1
Oct 25, 2022
Merged
Updates to feature/egressExtension
Part 1
#2759
kkeirstead
merged 65 commits into
dotnet:feature/egressExtension
from
kkeirstead:kkeirstead/egressExtensionP1_1
Oct 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… addition to supporting writing configuration in the main location
…extensibility/egress-extensibility.md
… - this did require (for now) some duplication of files
…d wiring up the fourth location (.dotnet\tools) to check for extensions
…ol install to be the landing site for third party extensions - needs refinement (currently uses some hard-coded values)
…; have not tested these changes
…ettle on a better mechanism for passing non string:string configuration
kkeirstead
commented
Oct 22, 2022
jander-msft
reviewed
Oct 24, 2022
jander-msft
reviewed
Oct 24, 2022
src/Extensions/AzureBlobStorage/AzureBlob/AzureBlobEgressProvider.AutoFlushStream.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Oct 24, 2022
src/Extensions/AzureBlobStorage/AzureBlob/AzureBlobEgressProvider.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Oct 24, 2022
jander-msft
reviewed
Oct 24, 2022
...osoft.Diagnostics.Monitoring.Tool.UnitTests/Egress/AzureBlob/AzureBlobEgressProviderTests.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Oct 24, 2022
Co-authored-by: Justin Anderson <[email protected]>
jander-msft
approved these changes
Oct 25, 2022
schmittjoseph
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I closed #2748 in favor of doing an even more limited set of changes. A couple of notes:
Release Notes Entry