Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to feature/egressExtension Part 1 #2759

Conversation

kkeirstead
Copy link
Member

Summary

I closed #2748 in favor of doing an even more limited set of changes. A couple of notes:

  • A large chunk of the changes is moving logging statements from the dotnet-monitor project to the Azure Blob Storage project in preparation for completely separating them.
  • The majority of newly introduced files are copies from within dotnet-monitor and don't need to be re-reviewed (unless there's a concern with the way the file was originally written).
  • To keep the changes smaller, I've eliminated some refactoring that has already been completed in my personal feature branch - as a result, there are some code paths/variables in this PR that are not being exercised.
Release Notes Entry

kkeirstead and others added 30 commits October 18, 2022 11:50
… addition to supporting writing configuration in the main location
… - this did require (for now) some duplication of files
…d wiring up the fourth location (.dotnet\tools) to check for extensions
…ol install to be the landing site for third party extensions - needs refinement (currently uses some hard-coded values)
@kkeirstead kkeirstead requested a review from a team as a code owner October 22, 2022 22:00
@kkeirstead kkeirstead merged commit c804040 into dotnet:feature/egressExtension Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants