Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Egress] Clean-Up For CopyBufferSize #4086

Merged
merged 1 commit into from
Mar 29, 2023
Merged

[Egress] Clean-Up For CopyBufferSize #4086

merged 1 commit into from
Mar 29, 2023

Conversation

kkeirstead
Copy link
Member

Summary

Cleaned up our usage of CopyBufferSize for Azure & S3. I'll leave comments around certain lines of code down below that need further context.

Release Notes Entry

@kkeirstead kkeirstead requested a review from a team as a code owner March 28, 2023 21:42
@ghost ghost added the needs-review label Mar 28, 2023
jander-msft
jander-msft approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@jander-msft jander-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job on the removal of the EgressAsync overload too!

@ghost ghost removed the needs-review label Mar 28, 2023
@kkeirstead kkeirstead merged commit b78612f into dotnet:feature/egressExtension Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktork wiktork wiktork left review comments

@jander-msft jander-msft jander-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkeirstead @wiktork @jander-msft