Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate does not use Field.defaultValue/value #3882

Closed
andlbrei opened this issue Aug 30, 2024 · 3 comments · Fixed by #3987
Closed

Iterate does not use Field.defaultValue/value #3882

andlbrei opened this issue Aug 30, 2024 · 3 comments · Fixed by #3987
Labels

Comments

@andlbrei
Copy link
Contributor

🐛 Bug Report

When using defaultValue or value in Field within Iterate the value is displayed and validated, but not stored when "submitting" the contents of the Iterate container.

Screen.Recording.2024-08-30.at.09.30.19.mov

To Reproduce

https://codesandbox.io/p/sandbox/iterate-defaultvalue-cdlmrl

Expected behavior

I expect defaultValue and value to be stored when submittin to the array.
Especially for PushContainer, where default values make the most sense to use.

Eufemia Version

10.45.0

@andlbrei andlbrei changed the title Iterate does not use defaultValue/value Iterate does not use Field.defaultValue/value Aug 30, 2024
@tujoworker
Copy link
Member

Thank you for reporting this issue 🫶
Yes, I agree, it should work. And I already tried the couple of last days to implement this, without seeing your issue (I just saw it right now).

It is tricky to get right, because of race conditions (when items adds a value, the context needs to be updated (rerender) but the iteration continues, but because of the rerender, the effect dep changes, and there we have the trouble), but I think I will give it another try, soon.

As of now, I added a warning, that it is not supported.

langz added a commit that referenced this issue Sep 2, 2024
…emPath (#3886)

Move out the warning from PR #3877 in regards of this issue #3882

---------

Co-authored-by: Anders <[email protected]>
@andlbrei
Copy link
Contributor Author

andlbrei commented Sep 4, 2024

Thanks for taking a look 👍

tujoworker pushed a commit that referenced this issue Sep 10, 2024
## [10.47.0](v10.46.0...v10.47.0) (2024-09-10)

### 📝 Documentation

* add component translations table to properties docs ([#3902](#3902)) ([66dd12e](66dd12e))
* **useTheme:** updates docs to match TS type definitions ([#3901](#3901)) ([52aaab3](52aaab3))

### ✨ Features

* **Button:** rewise documented `title` prop with aria-label documentation ([#3863](#3863)) ([ea444c0](ea444c0))
* **CopyOnClick:** adds copyContent prop ([e5a91b6](e5a91b6))
* **countries:** Added missing countries from ISO 3166 [#3894](#3894) ([2992084](2992084))
* **countries:** Added missing countries from ISO 3166 [#3894](#3894) ([#3899](#3899)) ([ada0e92](ada0e92))
* **Forms:** extend validations in `Field.NationalIdentityNumber` ([#3888](#3888)) ([50cc26b](50cc26b))
* **Forms:** make it possible to reuse and extend internal validators ([#3908](#3908)) ([7c97bf5](7c97bf5))
* **Forms:** provide `connectWithPath` in the validator and onBlurValidator to get values from other fields/paths ([#3895](#3895)) ([f4cf06f](f4cf06f))
* **Value.Date:** adds numeric variant ([#3907](#3907)) ([b03e199](b03e199))

### 🐛 Bug Fixes

* **Accordion:** deprecate (rename) expandBehaviour in favor of expandBehavior ([#3905](#3905)) ([76143b0](76143b0))
* **Breakpoint:** ensure matching breakpoint ranges in mixins with docs & hooks ([#3896](#3896)) ([260fcaf](260fcaf))
* **Flex:** enhance handling of React fragments ([#3892](#3892)) ([156c805](156c805))
* **Forms:** enhance cleanup routine of fields ([#3885](#3885)) ([388e0b2](388e0b2)), closes [#3877](#3877)
* **Forms:** ensure label supports HTML formatting ([#3911](#3911)) ([227569c](227569c))
* **Forms:** ensure labels do update when they change (async fields) ([#3910](#3910)) ([bc40449](bc40449))
* **Forms:** warn on value prop usage on fields inside iterate with itemPath ([#3886](#3886)) ([116820d](116820d)), closes [#3877](#3877) [#3882](#3882)
* **LabelDescription:** nothing was returned ([#3898](#3898)) ([3452855](3452855))
tujoworker pushed a commit that referenced this issue Oct 11, 2024
## [10.52.0](v10.51.2...v10.52.0) (2024-10-11)

### 📝 Documentation

* **NationalIdentityNumber:** add docs about validation ([#4077](#4077)) ([51bfd80](51bfd80))
* **OrganizationNumber:** adds docs about validation ([#4078](#4078)) ([c785c51](c785c51))

### 🐛 Bug Fixes

* **Autocomplete:** Show whole suggestion list after item selection ([#4060](#4060)) ([0acf061](0acf061))
* **Field.NationalIdentityNumber:** validate on all digits(not only 11 digits) ([#4079](#4079)) ([7c34fc9](7c34fc9))
* **Field.OrganizationNumber:** should validate on all digits(not only when 9) ([#4071](#4071)) ([08a4b51](08a4b51))
* **Forms:** add support for `Form.SubmitConfirmation` inside Wizard ([#4088](#4088)) ([e1167a4](e1167a4)), closes [#4086](#4086)
* **Forms:** don't call internal `exportValidators` when they not are exported as an array ([#4113](#4113)) ([cd54ed0](cd54ed0)), closes [#4106](#4106)
* **Forms:** ensure `emptyValue` is set in the data context when defined ([#4111](#4111)) ([dcc5694](dcc5694)), closes [#4070](#4070)
* **Forms:** ensure `onBlurValidator` gets called when `validateInitially` is true ([#4069](#4069)) ([59cf6c5](59cf6c5)), closes [#4068](#4068) [#4066](#4066)
* **Forms:** ensure Field.SelectCountry has a fallback locale (nb-NO) ([#4114](#4114)) ([568229a](568229a))
* **Forms:** ensure Form.clearData works in React.StrictMode ([#4053](#4053)) ([da0c93a](da0c93a)), closes [#4048](#4048)
* **Forms:** Fix use of unpolyfilled structuredClone in useData hook ([#4108](#4108)) ([1f59f10](1f59f10))
* **Forms:** keep `Iterate.EditContainer` open when falsy value or empty object was given as the iterate value ([#4087](#4087)) ([e932059](e932059)), closes [#4046](#4046)
* **Forms:** show error on every value change when using exported validators ([#4068](#4068)) ([cab6d01](cab6d01)), closes [#4067](#4067)
* **Icon:** icon property typing should accept FormStatus icons ([#4091](#4091)) ([f49eb34](f49eb34))
* **NationalIdentityNumber:** use `onBlurValidator` instead of `validator` ([#3982](#3982)) ([0a93755](0a93755))
* **Typography:** match medium heading font size in Sbanken theme ([#4039](#4039)) ([ce50529](ce50529))

### ✨ Features

* **Forms:** add `bubbleValidation` to Form.Isolation and Iterate.PushContainer to prevent the form from being submitted when there are fields with errors ([#4103](#4103)) ([880f870](880f870)), closes [#4072](#4072)
* **Forms:** add `createMinimumAgeValidator` to Field.NationalIdentityNumber make a customizable `adultValidator` ([#4057](#4057)) ([6c20ba2](6c20ba2))
* **Forms:** add `Form.useSnapshot` hook to handle snapshots of data ([#4102](#4102)) ([d451793](d451793))
* **Forms:** add `isolatedData` prop to `Iterate.PushContainer` ([#4076](#4076)) ([ede5f8e](ede5f8e))
* **Forms:** add `isValid` to Form.Visibility for showing content based on the validation of a field ([#4038](#4038)) ([7536752](7536752))
* **Forms:** add `Iterate.ItemNo` component ([#4095](#4095)) ([c736c9e](c736c9e))
* **Forms:** add `transformLabel` to all Value.* component ([#4056](#4056)) ([d63e472](d63e472))
* **Forms:** add support for `defaultValue` (and `value`) for fields used in `Iterate.Array` ([#3987](#3987)) ([afbdddf](afbdddf)), closes [#3882](#3882)
* **Forms:** add support for `id` for when using dynamic steps with `activeWhen` ([#4093](#4093)) ([248da92](248da92))
* **Forms:** remove internal pattern from `Field.NationalIdentityNumber` in favor of the internal validator ([#4098](#4098)) ([fb35722](fb35722))
* **Forms:** remove internal pattern from `Field.OrganizationNumber` in favor of the internal validator ([#4092](#4092)) ([e829f8b](e829f8b)), closes [#4073](#4073)
* **Skeleton:** stop animation after 30 seconds ([#3479](#3479)) ([f67b3bb](f67b3bb))
* **Value.PhoneNumber and NumberFormat:** displays country code using prefix `+` instead of `00` ([#4051](#4051)) ([fb363d0](fb363d0))
@tujoworker
Copy link
Member

🎉 This issue has been resolved in version 10.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants