Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Forms): add bubbleValidation to Form.Isolation and Iterate.PushContainer to prevent the form from being submitted when there are fields with errors #4103

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat(Forms): add bubbleValidation to Form.Isolation and Iterate.PushContainer to prevent the form from being submitted when there are fields with errors #4103

merged 1 commit into from
Oct 11, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Oct 9, 2024 •
edited
Loading

Partially solves #4072

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia 🛑 Canceled (Inspect) Oct 11, 2024 8:04am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Oct 9, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker force-pushed the feat/isolate-delegate-validation branch from 834e0c2 to 7e4065c Compare October 10, 2024 05:35
@langz
Copy link
Contributor

langz commented Oct 10, 2024 •
edited
Loading

delegateValidation, maybe we together could come up with a better name?
When I think of delegate, I'm thinking that it delegates the validation to someone or something, but in delegateValidation we don't say to what/who we delegate it to?
Is delegate the correct wording, when we don't have a "recipient" 🤔

Thoughts @andlbrei @tujoworker ?

@andlbrei
Copy link
Contributor

elevateValidation or something similar?
Or something like validateGlobally, but with a different term than "global" perhaps...

@tujoworker tujoworker force-pushed the feat/isolate-delegate-validation branch from 7e4065c to 0fa6273 Compare October 10, 2024 13:04
@tujoworker tujoworker changed the title feat(Forms): add delegateValidation to Form.Isolation and Iterate.PushContainer to prevent the form from being submitted when there are fields with errors feat(Forms): add bubbleValidation to Form.Isolation and Iterate.PushContainer to prevent the form from being submitted when there are fields with errors Oct 10, 2024
langz
langz approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫧

@tujoworker tujoworker force-pushed the feat/isolate-delegate-validation branch 2 times, most recently from b13fd95 to 7f28b22 Compare October 11, 2024 07:37
@tujoworker
feat(Forms): add bubbleValidation to Form.Isolation and Iterate.Pus…
c6bbdbb 
…hContainer to prevent the form from being submitted when there are fields with errors
@tujoworker tujoworker force-pushed the feat/isolate-delegate-validation branch from 7f28b22 to c6bbdbb Compare October 11, 2024 07:37
@tujoworker tujoworker merged commit 880f870 into main Oct 11, 2024
10 checks passed
@tujoworker tujoworker deleted the feat/isolate-delegate-validation branch October 11, 2024 09:55
tujoworker pushed a commit that referenced this pull request Oct 11, 2024
@semantic-release-bot
chore(release): 10.52.0 [skip ci]
7789277 
## [10.52.0](v10.51.2...v10.52.0) (2024-10-11)

### 📝 Documentation

* **NationalIdentityNumber:** add docs about validation ([#4077](#4077)) ([51bfd80](51bfd80))
* **OrganizationNumber:** adds docs about validation ([#4078](#4078)) ([c785c51](c785c51))

### 🐛 Bug Fixes

* **Autocomplete:** Show whole suggestion list after item selection ([#4060](#4060)) ([0acf061](0acf061))
* **Field.NationalIdentityNumber:** validate on all digits(not only 11 digits) ([#4079](#4079)) ([7c34fc9](7c34fc9))
* **Field.OrganizationNumber:** should validate on all digits(not only when 9) ([#4071](#4071)) ([08a4b51](08a4b51))
* **Forms:** add support for `Form.SubmitConfirmation` inside Wizard ([#4088](#4088)) ([e1167a4](e1167a4)), closes [#4086](#4086)
* **Forms:** don't call internal `exportValidators` when they not are exported as an array ([#4113](#4113)) ([cd54ed0](cd54ed0)), closes [#4106](#4106)
* **Forms:** ensure `emptyValue` is set in the data context when defined ([#4111](#4111)) ([dcc5694](dcc5694)), closes [#4070](#4070)
* **Forms:** ensure `onBlurValidator` gets called when `validateInitially` is true ([#4069](#4069)) ([59cf6c5](59cf6c5)), closes [#4068](#4068) [#4066](#4066)
* **Forms:** ensure Field.SelectCountry has a fallback locale (nb-NO) ([#4114](#4114)) ([568229a](568229a))
* **Forms:** ensure Form.clearData works in React.StrictMode ([#4053](#4053)) ([da0c93a](da0c93a)), closes [#4048](#4048)
* **Forms:** Fix use of unpolyfilled structuredClone in useData hook ([#4108](#4108)) ([1f59f10](1f59f10))
* **Forms:** keep `Iterate.EditContainer` open when falsy value or empty object was given as the iterate value ([#4087](#4087)) ([e932059](e932059)), closes [#4046](#4046)
* **Forms:** show error on every value change when using exported validators ([#4068](#4068)) ([cab6d01](cab6d01)), closes [#4067](#4067)
* **Icon:** icon property typing should accept FormStatus icons ([#4091](#4091)) ([f49eb34](f49eb34))
* **NationalIdentityNumber:** use `onBlurValidator` instead of `validator` ([#3982](#3982)) ([0a93755](0a93755))
* **Typography:** match medium heading font size in Sbanken theme ([#4039](#4039)) ([ce50529](ce50529))

### ✨ Features

* **Forms:** add `bubbleValidation` to Form.Isolation and Iterate.PushContainer to prevent the form from being submitted when there are fields with errors ([#4103](#4103)) ([880f870](880f870)), closes [#4072](#4072)
* **Forms:** add `createMinimumAgeValidator` to Field.NationalIdentityNumber make a customizable `adultValidator` ([#4057](#4057)) ([6c20ba2](6c20ba2))
* **Forms:** add `Form.useSnapshot` hook to handle snapshots of data ([#4102](#4102)) ([d451793](d451793))
* **Forms:** add `isolatedData` prop to `Iterate.PushContainer` ([#4076](#4076)) ([ede5f8e](ede5f8e))
* **Forms:** add `isValid` to Form.Visibility for showing content based on the validation of a field ([#4038](#4038)) ([7536752](7536752))
* **Forms:** add `Iterate.ItemNo` component ([#4095](#4095)) ([c736c9e](c736c9e))
* **Forms:** add `transformLabel` to all Value.* component ([#4056](#4056)) ([d63e472](d63e472))
* **Forms:** add support for `defaultValue` (and `value`) for fields used in `Iterate.Array` ([#3987](#3987)) ([afbdddf](afbdddf)), closes [#3882](#3882)
* **Forms:** add support for `id` for when using dynamic steps with `activeWhen` ([#4093](#4093)) ([248da92](248da92))
* **Forms:** remove internal pattern from `Field.NationalIdentityNumber` in favor of the internal validator ([#4098](#4098)) ([fb35722](fb35722))
* **Forms:** remove internal pattern from `Field.OrganizationNumber` in favor of the internal validator ([#4092](#4092)) ([e829f8b](e829f8b)), closes [#4073](#4073)
* **Skeleton:** stop animation after 30 seconds ([#3479](#3479)) ([f67b3bb](f67b3bb))
* **Value.PhoneNumber and NumberFormat:** displays country code using prefix `+` instead of `00` ([#4051](#4051)) ([fb363d0](fb363d0))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langz langz langz approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tujoworker @langz @andlbrei