Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form.SubmitConfirmation crashes the app when place in a Wizard #4086

Closed
andlbrei opened this issue Oct 8, 2024 · 3 comments · Fixed by #4088 or #4128
Closed

Form.SubmitConfirmation crashes the app when place in a Wizard #4086

andlbrei opened this issue Oct 8, 2024 · 3 comments · Fixed by #4088 or #4128
Labels

Comments

@andlbrei
Copy link
Contributor

andlbrei commented Oct 8, 2024

🐛 Bug Report

App crashes when trying to use Form.SubmitConfirmation within a Wizard.

TypeError
Cannot convert undefined or null to object
    at removeUndefinedProps (https://586y6z.csb.app/node_modules/
dnb/eufemia/shared/component-helper.js:639:10
    at eval (https://586y6z.csb.app/node_modules/
dnb/eufemia/extensions/forms/Form/SubmitConfirmation/SubmitConfirmation.js:103:65

To Reproduce

Put a Form.SubmitConfirmation in the last step of a Wizard
https://codesandbox.io/p/sandbox/form-submit-confirmation-586y6z

Expected behavior

Expect it to work as it does when it is placed as a child of Form.Handler.

Eufemia Version

10.51.2

tujoworker pushed a commit that referenced this issue Oct 11, 2024
## [10.52.0](v10.51.2...v10.52.0) (2024-10-11)

### 📝 Documentation

* **NationalIdentityNumber:** add docs about validation ([#4077](#4077)) ([51bfd80](51bfd80))
* **OrganizationNumber:** adds docs about validation ([#4078](#4078)) ([c785c51](c785c51))

### 🐛 Bug Fixes

* **Autocomplete:** Show whole suggestion list after item selection ([#4060](#4060)) ([0acf061](0acf061))
* **Field.NationalIdentityNumber:** validate on all digits(not only 11 digits) ([#4079](#4079)) ([7c34fc9](7c34fc9))
* **Field.OrganizationNumber:** should validate on all digits(not only when 9) ([#4071](#4071)) ([08a4b51](08a4b51))
* **Forms:** add support for `Form.SubmitConfirmation` inside Wizard ([#4088](#4088)) ([e1167a4](e1167a4)), closes [#4086](#4086)
* **Forms:** don't call internal `exportValidators` when they not are exported as an array ([#4113](#4113)) ([cd54ed0](cd54ed0)), closes [#4106](#4106)
* **Forms:** ensure `emptyValue` is set in the data context when defined ([#4111](#4111)) ([dcc5694](dcc5694)), closes [#4070](#4070)
* **Forms:** ensure `onBlurValidator` gets called when `validateInitially` is true ([#4069](#4069)) ([59cf6c5](59cf6c5)), closes [#4068](#4068) [#4066](#4066)
* **Forms:** ensure Field.SelectCountry has a fallback locale (nb-NO) ([#4114](#4114)) ([568229a](568229a))
* **Forms:** ensure Form.clearData works in React.StrictMode ([#4053](#4053)) ([da0c93a](da0c93a)), closes [#4048](#4048)
* **Forms:** Fix use of unpolyfilled structuredClone in useData hook ([#4108](#4108)) ([1f59f10](1f59f10))
* **Forms:** keep `Iterate.EditContainer` open when falsy value or empty object was given as the iterate value ([#4087](#4087)) ([e932059](e932059)), closes [#4046](#4046)
* **Forms:** show error on every value change when using exported validators ([#4068](#4068)) ([cab6d01](cab6d01)), closes [#4067](#4067)
* **Icon:** icon property typing should accept FormStatus icons ([#4091](#4091)) ([f49eb34](f49eb34))
* **NationalIdentityNumber:** use `onBlurValidator` instead of `validator` ([#3982](#3982)) ([0a93755](0a93755))
* **Typography:** match medium heading font size in Sbanken theme ([#4039](#4039)) ([ce50529](ce50529))

### ✨ Features

* **Forms:** add `bubbleValidation` to Form.Isolation and Iterate.PushContainer to prevent the form from being submitted when there are fields with errors ([#4103](#4103)) ([880f870](880f870)), closes [#4072](#4072)
* **Forms:** add `createMinimumAgeValidator` to Field.NationalIdentityNumber make a customizable `adultValidator` ([#4057](#4057)) ([6c20ba2](6c20ba2))
* **Forms:** add `Form.useSnapshot` hook to handle snapshots of data ([#4102](#4102)) ([d451793](d451793))
* **Forms:** add `isolatedData` prop to `Iterate.PushContainer` ([#4076](#4076)) ([ede5f8e](ede5f8e))
* **Forms:** add `isValid` to Form.Visibility for showing content based on the validation of a field ([#4038](#4038)) ([7536752](7536752))
* **Forms:** add `Iterate.ItemNo` component ([#4095](#4095)) ([c736c9e](c736c9e))
* **Forms:** add `transformLabel` to all Value.* component ([#4056](#4056)) ([d63e472](d63e472))
* **Forms:** add support for `defaultValue` (and `value`) for fields used in `Iterate.Array` ([#3987](#3987)) ([afbdddf](afbdddf)), closes [#3882](#3882)
* **Forms:** add support for `id` for when using dynamic steps with `activeWhen` ([#4093](#4093)) ([248da92](248da92))
* **Forms:** remove internal pattern from `Field.NationalIdentityNumber` in favor of the internal validator ([#4098](#4098)) ([fb35722](fb35722))
* **Forms:** remove internal pattern from `Field.OrganizationNumber` in favor of the internal validator ([#4092](#4092)) ([e829f8b](e829f8b)), closes [#4073](#4073)
* **Skeleton:** stop animation after 30 seconds ([#3479](#3479)) ([f67b3bb](f67b3bb))
* **Value.PhoneNumber and NumberFormat:** displays country code using prefix `+` instead of `00` ([#4051](#4051)) ([fb363d0](fb363d0))
@tujoworker
Copy link
Member

🎉 This issue has been resolved in version 10.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@andlbrei
Copy link
Contributor Author

@tujoworker this still crashes, but with a different message this time.
I updated the CSB to use 10.52.0

Firefox:

TypeError
internalDataRef is undefined
SubmitConfirmation/getParamsRef<@https://586y6z.csb.app/node_modules/
dnb/eufemia/extensions/forms/Form/SubmitConfirmation/SubmitConfirmation.js:93:7

SubmitConfirmation@https://586y6z.csb.app/node_modules/
dnb/eufemia/extensions/forms/Form/SubmitConfirmation/SubmitConfirmation.js:147:348

Edge:

TypeError
Cannot read properties of undefined (reading 'current')
    at Object.eval [as current] (https://586y6z.csb.app/node_modules/
dnb/eufemia/extensions/forms/Form/SubmitConfirmation/SubmitConfirmation.js:93:29

    at SubmitConfirmation (https://586y6z.csb.app/node_modules/
dnb/eufemia/extensions/forms/Form/SubmitConfirmation/SubmitConfirmation.js:147:348

@andlbrei andlbrei reopened this Oct 14, 2024
langz added a commit that referenced this issue Oct 15, 2024
tujoworker pushed a commit that referenced this issue Oct 15, 2024
## [10.52.1](v10.52.0...v10.52.1) (2024-10-15)

### 📝 Documentation

* **OrganizationNumber:** adds docs about validation ([1dbe8f0](1dbe8f0))
* **OrganizationNumber:** adds docs about validation ([#4122](#4122)) ([0c3eae7](0c3eae7))

### 🐛 Bug Fixes

* **Forms:** add support for Form.SubmitConfirmation inside Wizard (renderWithState) ([2d2de53](2d2de53))
* **Forms:** add support for Form.SubmitConfirmation inside Wizard (renderWithState) ([#4128](#4128)) ([63878cc](63878cc)), closes [#4086](#4086)
* **Forms:** UI aligments of the ChildrenWithAge block ([#4126](#4126)) ([f2193f0](f2193f0))
@tujoworker
Copy link
Member

🎉 This issue has been resolved in version 10.52.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment