-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Forms): auto-open iterate container items when validation errors and make Iterate.Toolbar
fully customizable
#3877
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
03baf8d
to
4e6f93a
Compare
4edc95b
to
3031032
Compare
3031032
to
0c6e41c
Compare
724a3c7
to
f8accba
Compare
f8accba
to
8f8c5e0
Compare
8f8c5e0
to
1e0bc7e
Compare
daa7c1f
to
ccd44b5
Compare
ccd44b5
to
3677715
Compare
This comment was marked as outdated.
This comment was marked as outdated.
3677715
to
aa5c4f1
Compare
f0c4b9a
to
0c90c64
Compare
Can you test the keyboard usage again? Have made some improvements there. |
06506cd
to
7e603a0
Compare
7e603a0
to
c66e459
Compare
This comment was marked as resolved.
This comment was marked as resolved.
https://eufemia-git-feat-iterate-container-mode-eufemia.vercel.app/uilib/extensions/forms/Iterate/Array/demos/#initially-open Screen.Recording.2024-09-11.at.23.06.03.movLooking like this(see the last error message): I believe this is newly introduced, as I did not experience this last week. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
a782027
to
d131df9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
...ages/dnb-eufemia/src/extensions/forms/Iterate/PushContainer/__tests__/PushContainer.test.tsx
Outdated
Show resolved
Hide resolved
...ages/dnb-eufemia/src/extensions/forms/Iterate/PushContainer/__tests__/PushContainer.test.tsx
Outdated
Show resolved
Hide resolved
…r/__tests__/PushContainer.test.tsx Co-authored-by: Anders <[email protected]>
…r/__tests__/PushContainer.test.tsx Co-authored-by: Anders <[email protected]>
I'm still able to reproduce this now. |
… for hiding buttons when there is only one item in the array (#3919) Based on #3877 Quick example using the new Toolbar variant: ```tsx <Form.Handler> <Iterate.Array path="/countries" defaultValue={[null]}> <Iterate.ViewContainer toolbarVariant="minimumOneItem" > <Value.SelectCountry label="Land du er statsborger i" itemPath="/" /> </Iterate.ViewContainer> <Iterate.EditContainer toolbarVariant="minimumOneItem" > <Field.SelectCountry label="Land du er statsborger i" itemPath="/" required /> </Iterate.EditContainer> </Iterate.Array> <Iterate.PushButton path="/countries" pushValue={null} text="Legg til flere statsborgerskap" /> </Form.Handler> ``` --------- Co-authored-by: Anders <[email protected]>
## [10.48.0](v10.47.0...v10.48.0) (2024-09-12) ### 🐛 Bug Fixes * **countries:** Fixes wrong country code for Martinique [#3915](#3915) ([a9f86e4](a9f86e4)) * **countries:** Remove outdated countries [#3915](#3915) ([36ef5cf](36ef5cf)) * **Forms:** rename 'Macedonia' to 'North Macedonia' ([#3918](#3918)) ([a4eb8a4](a4eb8a4)) * **Forms:** rename "Hviterussland" to "Belarus" ([#3917](#3917)) ([702118a](702118a)) * removes outdated countries based on ISO 3166-1 alpha-2 ([#3916](#3916)) ([a045acd](a045acd)) ### ✨ Features * **Forms:** add `toolbarVariant="minimumOneItem"` to Iterate.Toolbar for hiding buttons when there is only one item in the array ([#3919](#3919)) ([3367a77](3367a77)), closes [#3877](#3877) * **Forms:** add `validator` support to Iterate.Array ([#3926](#3926)) ([6fd439e](6fd439e)) * **Forms:** auto-open Form.Section container when fields have errors and add `validateInitially` prop ([#3878](#3878)) ([9b49006](9b49006)) * **Forms:** auto-open iterate containers when validation errors and make `Iterate.Toolbar` fully customizable ([#3877](#3877)) ([52326bf](52326bf)), closes [#3919](#3919) * **Forms:** show optional label when a field uses `required={false}` and add `labelSuffix` prop to each field ([#3921](#3921)) ([60e440a](60e440a)) * **Wizard:** add `preventNavigation` callback function to `onStepChange` ([#3924](#3924)) ([5ec2772](5ec2772))
🎉 This PR is included in version 10.48.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
toolbarVariant="minimumOneItem"
to Iterate.Toolbar for hiding buttons when there is only one item in the array #3919 has been created.Quick example of a fully customized Toolbar: