Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes outdated countries based on ISO 3166-1 alpha-2 #3916

Merged

Conversation

andlbrei
Copy link
Contributor

@andlbrei andlbrei self-assigned this Sep 10, 2024
@andlbrei andlbrei linked an issue Sep 10, 2024 that may be closed by this pull request
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 0:23am

@andlbrei andlbrei requested a review from joakbjerk September 10, 2024 12:17
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@joakbjerk joakbjerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@langz langz changed the title 3915 country list contains outdated countries + one bug fix: removes outdated countries from country list Sep 10, 2024
@langz langz changed the title fix: removes outdated countries from country list fix: removes outdated countries based on ISO 3166-1 alpha-2 Sep 10, 2024
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great, looks good to me :)

@langz
Copy link
Contributor

langz commented Sep 10, 2024

If this fix is very urgent, we could make it available "now" in v10.47.1.

If not, then we'll include it in the future release v10.48.0, probably released by the end of the week or so.

@andlbrei, what do you think?

@andlbrei
Copy link
Contributor Author

@langz it's not urgent, so you can wait until the next release

@andlbrei andlbrei merged commit a045acd into main Sep 10, 2024
15 checks passed
@andlbrei andlbrei deleted the 3915-country-list-contains-outdated-countries-+-one-bug branch September 10, 2024 12:42
@langz
Copy link
Contributor

langz commented Sep 10, 2024

Thanks again @andlbrei, and thanks so much for the PR 🎸

When this PR got merged, it resulted in 3 seperate commits on main(2 of yours + 1 merge commit, since the "create a merge commit"-strategy was used upon merging):
image

In the future, when merging the PR it would be even better if you could use merge strategy "squash and merge"(as it would result in a better version history in main branch, or atleast less commits):
Screenshot 2024-09-10 at 14 48 00

When using "squash and merge", it will suggest to use the PR title as commit message or you can provide one yourself:
Screenshot 2024-09-10 at 14 49 14

Here's also a small guide on how to structure the commit message.
https://eufemia.dnb.no/contribute/style-guides/git/#commit-messages

Thanks again ❤️

@andlbrei
Copy link
Contributor Author

@langz sorry! I'll be sure to do it properly next time

tujoworker pushed a commit that referenced this pull request Sep 12, 2024
## [10.48.0](v10.47.0...v10.48.0) (2024-09-12)

### 🐛 Bug Fixes

* **countries:** Fixes wrong country code for Martinique [#3915](#3915) ([a9f86e4](a9f86e4))
* **countries:** Remove outdated countries [#3915](#3915) ([36ef5cf](36ef5cf))
* **Forms:** rename 'Macedonia' to 'North Macedonia' ([#3918](#3918)) ([a4eb8a4](a4eb8a4))
* **Forms:** rename "Hviterussland" to "Belarus" ([#3917](#3917)) ([702118a](702118a))
* removes outdated countries based on ISO 3166-1 alpha-2 ([#3916](#3916)) ([a045acd](a045acd))

### ✨ Features

* **Forms:** add `toolbarVariant="minimumOneItem"` to Iterate.Toolbar for hiding buttons when there is only one item in the array ([#3919](#3919)) ([3367a77](3367a77)), closes [#3877](#3877)
* **Forms:** add `validator` support to Iterate.Array ([#3926](#3926)) ([6fd439e](6fd439e))
* **Forms:** auto-open Form.Section container when fields have errors and add `validateInitially` prop  ([#3878](#3878)) ([9b49006](9b49006))
* **Forms:** auto-open iterate containers when validation errors and make `Iterate.Toolbar` fully customizable ([#3877](#3877)) ([52326bf](52326bf)), closes [#3919](#3919)
* **Forms:** show optional label when a field uses `required={false}` and add `labelSuffix` prop to each field ([#3921](#3921)) ([60e440a](60e440a))
* **Wizard:** add `preventNavigation` callback function to `onStepChange` ([#3924](#3924)) ([5ec2772](5ec2772))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.48.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Country list contains outdated countries + one bug
4 participants