Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature for making symlinks relative #139

Closed
MattesMrzik opened this issue Nov 13, 2023 · 1 comment · Fixed by #140 or #134
Closed

Feature for making symlinks relative #139

MattesMrzik opened this issue Nov 13, 2023 · 1 comment · Fixed by #140 or #134
Assignees
@MattesMrzik
Labels
enhancement New feature or request
Milestone
release:2024.03.001

Comments

@MattesMrzik
Copy link
Contributor

Sometimes it is desired that symlinks point to relative locations not to absolute ones. For example if a link in dir1 points to some file inside dir1 and then dir1 is moved or renamed. Then, if the link was relative instead of absolute, it is still functioning.
@MattesMrzik MattesMrzik added the enhancement New feature or request label Nov 13, 2023
@MattesMrzik MattesMrzik self-assigned this Nov 13, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Nov 13, 2023
@tobka777 tobka777 moved this from 🆕 New to 🏗 In progress in IDEasy board Nov 13, 2023
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Nov 13, 2023
@MattesMrzik
devonfw#139: relative symlink feature
c970265
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Nov 13, 2023
@MattesMrzik
devonfw#139: clean up
a360f9f
@MattesMrzik MattesMrzik mentioned this issue Nov 13, 2023
Merged
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Nov 13, 2023
@MattesMrzik
Merge remote-tracking branch 'origin/feature/devonfw#139-feature-for-…
d9f33a8 
…making-symlinks-relative' into feature/devonfw#13-implement-ToolCommandlet-for-AWS-CLI
@MattesMrzik MattesMrzik moved this from 🏗 In progress to Team Review in IDEasy board Nov 16, 2023
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Nov 16, 2023
@MattesMrzik
devonfw#139: added check for windows when rewriting junction
e295e9d
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Nov 22, 2023
@tobka777 tobka777 moved this from 🆕 New to Team Review in IDEasy board Nov 22, 2023
@hohwille hohwille assigned hohwille and unassigned hohwille Nov 23, 2023
@tobka777 tobka777 moved this from Team Review to 🏗 In progress in IDEasy board Nov 24, 2023
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Nov 28, 2023
@MattesMrzik
devonfw#139: rewrote test, one still missing
66f09cf
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Nov 29, 2023
@MattesMrzik
devonfw#139: improved test, removed makeSymlinkRelative
75eb709
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Nov 29, 2023
@MattesMrzik
Merge remote-tracking branch 'upstream/main' into feature/devonfw#139-…
0719c4f 
…feature-for-making-symlinks-relative

# Conflicts:
#	cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Nov 29, 2023
@MattesMrzik
devonfw#139: small bugfix in test
cf287fe
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Nov 29, 2023
@MattesMrzik
devonfw#139: fixed linux bug
24f3307
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Nov 29, 2023
@MattesMrzik
Merge remote-tracking branch 'origin/feature/devonfw#139-feature-for-…
70aef25 
…making-symlinks-relative' into feature/devonfw#13-implement-ToolCommandlet-for-AWS-CLI

# Conflicts:
#	cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Dec 4, 2023
@MattesMrzik
devonfw#139: added comments to test
496e434
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Dec 11, 2023
@MattesMrzik
devonfw#139: impl. first change req from PR
8d84bee
@hohwille hohwille linked a pull request Dec 11, 2023 that will close this issue
fileaccess delete symlink fix #134
Merged
hohwille pushed a commit that referenced this issue Dec 11, 2023
@MattesMrzik
#139: fileaccess delete symlink fix (#134)
e86add0
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Dec 11, 2023
@hohwille
Copy link
Member

Was auto-closed by git. Reopening so it will be closed with PR #140

@hohwille hohwille reopened this Dec 11, 2023
@github-project-automation github-project-automation bot moved this from ✅ Done to 📋 Backlog in IDEasy board Dec 11, 2023
@hohwille hohwille mentioned this issue Dec 11, 2023
Merged
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Dec 11, 2023
@MattesMrzik
devonfw#139: fixed bug
18ec98f
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Dec 11, 2023
@MattesMrzik
Merge remote-tracking branch 'origin/feature/devonfw#139-feature-for-…
736935c 
…making-symlinks-relative' into feature/devonfw#139-feature-for-making-symlinks-relative
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Dec 11, 2023
@MattesMrzik
devonfw#139: changed fallback in case of windows junctions
304c48c
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Dec 11, 2023
@MattesMrzik
devonfw#139: fixed toAbsolute, which was wrong, more tests
f8dfe79
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Dec 12, 2023
@MattesMrzik
devonfw#139: modified tests and adaptPath
b3994c8
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Dec 12, 2023
@MattesMrzik
devonfw#139: always use toRealPath in symlink
7683f5b
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Dec 12, 2023
@MattesMrzik
devonfw#139: clean up
be24f11
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Dec 12, 2023
@MattesMrzik
Merge branch 'main' of https://github.com/devonfw/IDEasy into feature/d…
985e964 
…evonfw#139-feature-for-making-symlinks-relative

# Conflicts:
#	cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java
@tobka777 tobka777 moved this from 📋 Backlog to 🏗 In progress in IDEasy board Dec 14, 2023
hohwille added a commit to MattesMrzik/IDEasy that referenced this issue Jan 4, 2024
@hohwille
Merge branch 'main' into feature/devonfw#139-feature-for-making-symli…
f1f835b 
…nks-relative
hohwille pushed a commit that referenced this issue Jan 4, 2024
@MattesMrzik
#139: feature for making symlinks relative (#140)
bae97bc
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Jan 4, 2024
MattesMrzik added a commit to MattesMrzik/IDEasy that referenced this issue Jan 8, 2024
@MattesMrzik
Merge branch 'main' of https://github.com/devonfw/IDEasy into feature/d…
eed90d7 
…evonfw#139-feature-for-making-symlinks-relative
@hohwille hohwille added this to the release:2024.03.001 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattesMrzik MattesMrzik

Labels
enhancement New feature or request
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.03.001
2 participants
@hohwille @MattesMrzik