Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileaccess delete symlink fix #134

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fileaccess delete symlink fix #134

merged 2 commits into from
Dec 11, 2023

Conversation

MattesMrzik
Copy link
Contributor

Deleting a symlink resulted in an exception due to the call to deleteRecursive. This call was removed in the case of a symlink.

Deleting a symlink resulted in an exception due to the call to deleteRecursive. This call was removed in the case of a symlink.
@MattesMrzik MattesMrzik self-assigned this Nov 7, 2023
@salimbouch
Copy link
Contributor

looks good to me.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattesMrzik Thanks for finding and fixing this bug 👍
I already reviewed it as part of your other PR. However, as you created this PR, I can already approve and merge this.

@hohwille hohwille linked an issue Dec 11, 2023 that may be closed by this pull request
@hohwille hohwille merged commit e86add0 into devonfw:main Dec 11, 2023
2 checks passed
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. story-review marks PRs that will be presented in the sprint-review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Feature for making symlinks relative
3 participants