devonfw#139: clean up

MattesMrzik · Nov 13, 2023 · a360f9f · a360f9f
1 parent c970265
commit a360f9f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/cli/src/main/java/com/devonfw/tools/ide/io/FileAccess.java b/cli/src/main/java/com/devonfw/tools/ide/io/FileAccess.java
@@ -53,7 +53,7 @@ public interface FileAccess {
 
   /**
    * Symbolic links can point to relative or absolute paths. Here the link is converted to be relative. If the target of
-   * the link is again a link, then that lead is followed, until the target is not a link.
+   * the link is again a link, then that lead is not followed.
    *
    * @param link the {@link Path} of the symbolic link.
    */
@@ -64,7 +64,7 @@ public interface FileAccess {
    *
    * @param link the {@link Path} of the symbolic link.
    * @param followTarget - {@code true} if the target of the link is again a link, then that lead is followed, until the
-   *        target is not a link. - {@code false} if the target of the link is again a link, then that lead is no
+   *        target is not a link. - {@code false} if the target of the link is again a link, then that lead is not
    *        followed.
    */
   void makeSymlinkRelative(Path link, boolean followTarget);

diff --git a/cli/src/test/java/com/devonfw/tools/ide/io/FileAccessImplTest.java b/cli/src/test/java/com/devonfw/tools/ide/io/FileAccessImplTest.java
@@ -18,28 +18,21 @@
 
 public class FileAccessImplTest extends Assertions {
 
-  void arrangetestRelativeSymlinks(Path tempDir, FileAccess fileAccess) {
-
-  }
-
   @Test
   void testSymlink(@TempDir Path tempDir) {
 
     IdeContext context = IdeTestContextMock.get();
     FileAccess fileAccess = new FileAccessImpl(context);
-    // create a new directory
     Path dir = tempDir.resolve("dir");
     fileAccess.mkdirs(dir);
 
-    // create a new file using nio
     Path file = tempDir.resolve("file");
     try {
       Files.write(file, "Hello World!".getBytes());
     } catch (IOException e) {
-      throw new RuntimeException(e);
+      throw new RuntimeException("When preparing testSymlink writing of " + file + " failed. ", e);
     }
 
-    // try to create a symlink to the file using Files.createSymbolicLink
     Path link = tempDir.resolve("link");
     Path linkToLink = tempDir.resolve("linkToLink");
 
@@ -197,7 +190,7 @@ void testMakeSymlinkRelative(@TempDir Path tempDir) {
         }
       }
 
-      // redo move, and check later if symlinks still work
+      // redo move, and check in assert if symlinks still work
       fileAccess.move(parent, parent2);
 
       // assert