#13: implement tool commandlet for aws cli #122

MattesMrzik · 2023-10-27T15:05:40Z

resolves #13: The ToolCommandlet for AWS CLI was implemented. Still has a workaround that manually grants executable permissions to the binary under linux. This workaround can be removed if issue #132 is fixed.
This has already PR #140 merged into, since this tool builds upon features from this PR. So probably merge first #140, and then this one here.

Unrelated to the issue #13: Added @TempDir Path tempDir in testSave of EnvironmentVariablesPropertiesFileTest

hohwille

@MattesMrzik thanks for your PR. Already looks good 👍
I have added some review comments to give some guidance and direction even though your PR is still in WIP/draft state.

cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java

…mandlet-for-AWS-CLI

…making-symlinks-relative' into feature/devonfw#13-implement-ToolCommandlet-for-AWS-CLI

MattesMrzik · 2023-11-13T15:41:36Z

This has already PR #140 merged into, since this tool builds upon features from this PR. So probably merge first #140, and then this one here.

salimbouch

Looks good :) I added 2 comments that could make the code a little bit shorter.

cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java

hohwille · 2023-12-11T15:47:20Z

Should be merged after #139 has been merged.

…plement-ToolCommandlet-for-AWS-CLI # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java

…evonfw#13-implement-ToolCommandlet-for-AWS-CLI # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/io/FileAccess.java # cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java # cli/src/test/java/com/devonfw/tools/ide/io/FileAccessImplTest.java

coveralls · 2024-01-08T21:16:00Z

Pull Request Test Coverage Report for Build 7725548339

0 of 0 changed or added relevant lines in 0 files are covered.
15 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 55.799%

Files with Coverage Reduction	New Missed Lines	%
com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java	3	87.5%
com/devonfw/tools/ide/tool/ToolCommandlet.java	12	45.41%

Totals
Change from base Build 7709887816:	-0.2%
Covered Lines:	3650
Relevant Lines:	6301

💛 - Coveralls

@SuppressWarnings

changed comment and removed @SuppressWarnings(javadoc)

cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java

hohwille

@MattesMrzik great job. Looks good. Thanks for testing on Windows and Linux.
Thanks for the helpful comments. Thanks for improving the JUnits. 👍

BTW: You are decreasing the coverage by 0.3%. Pretty much noting but the current strict setup that @moritzLanger has created, prevents merging. So far I like this setup as it enforces us to continuously increase the coverage. However, we could discuss in the team meetings if we want to accept PRs with lets say coverage delta > -0.5%...
To get this merged faster, could you please add a little JUnit test method to increase coverage a very little?

…for-AWS-CLI

hohwille

@MattesMrzik sorry - I had a review comment that was pending and I forgot to submit it.
Can you please have a look?

I just rebased the PR and resolved merge conflicts so apart from the last comment we can merge.

cli/src/main/java/com/devonfw/tools/ide/common/SystemPath.java

cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java

Co-authored-by: Jörg Hohwiller <[email protected]>

…evonfw#13-implement-ToolCommandlet-for-AWS-CLI # Conflicts: # cli/src/main/resources/nls/Ide.properties # cli/src/main/resources/nls/Ide_de.properties

…' of https://www.github.com/MattesMrzik/IDEasy into feature/devonfw#13-implement-ToolCommandlet-for-AWS-CLI # Conflicts: # cli/src/main/resources/nls/Ide.properties # cli/src/main/resources/nls/Ide_de.properties

…for-AWS-CLI

hohwille

ready for merge 👍

MattesMrzik added 2 commits October 27, 2023 13:19

devonfw#13: implement aws toolcommandlet

4d07265

devonfw#13: added linux specific procedure to install aws

01f9484

MattesMrzik self-assigned this Oct 27, 2023

MattesMrzik changed the title ~~Feature/#13 implement tool commandlet for aws cli~~ #13 implement tool commandlet for aws cli Oct 28, 2023

MattesMrzik changed the title ~~#13 implement tool commandlet for aws cli~~ #13: implement tool commandlet for aws cli Oct 28, 2023

MattesMrzik marked this pull request as ready for review October 30, 2023 10:03

hohwille reviewed Oct 31, 2023

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java Outdated Show resolved Hide resolved

cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java Outdated Show resolved Hide resolved

MattesMrzik added 3 commits November 7, 2023 22:01

Merge branch 'devonfw:main' into feature/devonfw#13-implement-ToolCom…

bd4b999

…mandlet-for-AWS-CLI

aws toolcommandlet now for linux

a710192

aws extends localtoolcommandlet

e94cc15

MattesMrzik marked this pull request as draft November 9, 2023 10:31

MattesMrzik added 5 commits November 13, 2023 14:19

devonfw#139: relative symlink feature

c970265

devonfw#139: clean up

a360f9f

devonfw#13: before i merge branch 139: relative symlink into this branch

15d2525

Merge remote-tracking branch 'origin/feature/devonfw#139-feature-for-…

d9f33a8

…making-symlinks-relative' into feature/devonfw#13-implement-ToolCommandlet-for-AWS-CLI

devonfw#13: fix merge error and bug in Aws.moveAndProcessExtraction

42a008b

MattesMrzik marked this pull request as ready for review November 13, 2023 15:40

devonfw#139: added check for windows when rewriting junction

e295e9d

hohwille unassigned MattesMrzik Nov 23, 2023

hohwille requested a review from salimbouch November 23, 2023 10:05

hohwille assigned salimbouch Nov 23, 2023

salimbouch reviewed Nov 23, 2023

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java Show resolved Hide resolved

cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java Outdated Show resolved Hide resolved

salimbouch assigned MattesMrzik and unassigned salimbouch Nov 23, 2023

MattesMrzik assigned salimbouch and unassigned MattesMrzik Nov 27, 2023

MattesMrzik added 3 commits November 28, 2023 11:49

devonfw#13: implemented suggested improvements

4e1ba6f

devonfw#139: rewrote test, one still missing

66f09cf

devonfw#139: improved test, removed makeSymlinkRelative

75eb709

MattesMrzik assigned hohwille Dec 1, 2023

MattesMrzik added 2 commits January 8, 2024 21:41

Merge remote-tracking branch 'origin/main' into feature/devonfw#13-im…

eaa85fc

…plement-ToolCommandlet-for-AWS-CLI # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java

MattesMrzik added 3 commits January 8, 2024 22:27

devonfw#13: small change

2138357

changed comment and removed @SuppressWarnings(javadoc)

devonfw#13: reformatted comment

0b23360

devonfw#13: readded @SuppressWarnings("javadoc")

b5a2d4b

MattesMrzik requested a review from hohwille January 8, 2024 21:40

hohwille reviewed Jan 10, 2024

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java Show resolved Hide resolved

hohwille approved these changes Jan 10, 2024

View reviewed changes

Merge branch 'main' into feature/devonfw#13-implement-ToolCommandlet-…

208b39d

…for-AWS-CLI

MattesMrzik requested a review from hohwille January 15, 2024 08:20

Merge branch 'main' into feature/devonfw#13-implement-ToolCommandlet-…

fa619a9

…for-AWS-CLI

hohwille reviewed Jan 23, 2024

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/common/SystemPath.java Outdated Show resolved Hide resolved

hohwille reviewed Jan 23, 2024

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java Outdated Show resolved Hide resolved

MattesMrzik and others added 8 commits January 26, 2024 10:02

Update cli/src/main/java/com/devonfw/tools/ide/tool/aws/Aws.java

af01a32

Co-authored-by: Jörg Hohwiller <[email protected]>

devonfw#13: removed paths.add(path) in SystemPath.setPath

88b0e48

Merge branch 'main' of https://github.com/devonfw/IDEasy into feature/d…

e521c6b

…evonfw#13-implement-ToolCommandlet-for-AWS-CLI # Conflicts: # cli/src/main/resources/nls/Ide.properties # cli/src/main/resources/nls/Ide_de.properties

devonfw#13: added url to TODO issue

05f1576

devonfw#13: added missing import

f255f75

Merge branch 'main' into feature/devonfw#13-implement-ToolCommandlet-…

ce21ca6

…for-AWS-CLI

Merge branch 'main' into feature/devonfw#13-implement-ToolCommandlet-…

c358890

…for-AWS-CLI

hohwille approved these changes Jan 31, 2024

View reviewed changes

hohwille merged commit 905710a into devonfw:main Jan 31, 2024
3 checks passed

hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024

ndemirca added the commandlet label May 28, 2024

hohwille mentioned this pull request Aug 19, 2024

Add FileUtil.makeExecutable(Path) #542

Closed

hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Oct 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#13: implement tool commandlet for aws cli #122

#13: implement tool commandlet for aws cli #122

MattesMrzik commented Oct 27, 2023 •

edited

Loading

hohwille left a comment

MattesMrzik commented Nov 13, 2023 •

edited

Loading

salimbouch left a comment

hohwille commented Dec 11, 2023

coveralls commented Jan 8, 2024 •

edited

Loading

hohwille left a comment •

edited

Loading

hohwille left a comment

hohwille left a comment

#13: implement tool commandlet for aws cli #122

#13: implement tool commandlet for aws cli #122

Conversation

MattesMrzik commented Oct 27, 2023 • edited Loading

hohwille left a comment

Choose a reason for hiding this comment

MattesMrzik commented Nov 13, 2023 • edited Loading

salimbouch left a comment

Choose a reason for hiding this comment

hohwille commented Dec 11, 2023

coveralls commented Jan 8, 2024 • edited Loading

Pull Request Test Coverage Report for Build 7725548339

💛 - Coveralls

hohwille left a comment • edited Loading

Choose a reason for hiding this comment

hohwille left a comment

Choose a reason for hiding this comment

hohwille left a comment

Choose a reason for hiding this comment

MattesMrzik commented Oct 27, 2023 •

edited

Loading

MattesMrzik commented Nov 13, 2023 •

edited

Loading

coveralls commented Jan 8, 2024 •

edited

Loading

hohwille left a comment •

edited

Loading