Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): pin npm version to 8.5.2 in integration test #2000

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 7, 2022

[email protected] (published 3 days ago) doesn't seem working with node compat mode on mac and linux. This PR pins the npm version to 8.5.2.

closes #1999

@kt3k kt3k requested a review from bartlomieju as a code owner March 7, 2022 05:18
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why?

@kt3k
Copy link
Member Author

kt3k commented Mar 7, 2022

Haven't identified it yet. There seem no significant changes in npm/cli repository itself between 8.5.2 & 8.5.3, but they updated a lot of dependencies npm/cli#4490 npm/cli@v8.5.2...v8.5.3

@kt3k
Copy link
Member Author

kt3k commented Mar 7, 2022

Created an issue #2001

@kt3k kt3k merged commit a4f8983 into denoland:main Mar 7, 2022
@kt3k kt3k deleted the chore/pin-npm-to-8.5.2 branch March 7, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compat: npm install doesn't work on mac and linux since Mar 4
2 participants