Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): pin npm version to 8.5.2 in integration test #2000

Merged
merged 3 commits into from
Mar 7, 2022
Merged

chore(node): pin npm version to 8.5.2 in integration test #2000

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
472db8a
chore(node): pin npm version to 8.5.2 in integration test
kt3k Mar 7, 2022
c77ae63
chore: fmt
kt3k Mar 7, 2022
25ba24f
rerun ci
kt3k Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions node/integrationtest/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,26 +18,22 @@ Deno.test("integration test of compat mode", {
const expressPath = join(tempDir, "node_modules", "express");

await t.step("yarn add npm express", async () => {
await exec(`deno run --compat --unstable -A ${yarnUrl} add npm`, opts);
const stat = await Deno.lstat(join(npmPath, "package.json"));
assert(stat.isFile);
// FIXME(kt3k): [email protected] doesn't work with compat mode
await exec(
`deno run --compat --unstable -A ${yarnUrl} add [email protected]`,
opts,
);
assert((await Deno.lstat(join(npmPath, "package.json"))).isFile);
await exec(`deno run --compat --unstable -A ${yarnUrl} add express`, opts);
assert((await Deno.lstat(join(expressPath, "package.json"))).isFile);
});

// FIXME(kt3k): npm in compat mode is broken in Linux and Mac
if (Deno.build.os === "windows") {
await t.step("npm install gulp", async () => {
await exec(
`deno run --compat --unstable -A ${
join(npmPath, "index.js")
} install gulp`,
opts,
);
const stat = await Deno.lstat(join(gulpPath, "package.json"));
assert(stat.isFile);
});
}
await t.step("npm install gulp", async () => {
const npmCli = join(npmPath, "index.js");
await exec(`deno run --compat --unstable -A ${npmCli} install gulp`, opts);
const stat = await Deno.lstat(join(gulpPath, "package.json"));
assert(stat.isFile);
});

await t.step("run express example app", async () => {
await Deno.writeTextFile(
Expand Down