Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compat: [email protected] doesn't work with compat mode #2001

Closed
kt3k opened this issue Mar 7, 2022 · 4 comments · Fixed by #2004
Closed

compat: [email protected] doesn't work with compat mode #2001

kt3k opened this issue Mar 7, 2022 · 4 comments · Fixed by #2004
Assignees
@kt3k

Comments

@kt3k
Copy link
Member

kt3k commented Mar 7, 2022

npm install works with v8.5.2 with compat mode, but it doesn't with v8.5.3

diff between npm 8.5.2 and 8.5.3 npm/cli@v8.5.2...v8.5.3
@kt3k kt3k mentioned this issue Mar 7, 2022
Merged
@kt3k
Copy link
Member Author

kt3k commented Mar 7, 2022

npm install started hanging with compat mode with this commit npm/cli@3c17b69

In this commit the following modules are updated:

  • make-fetch-happen 10.0.3 -> 10.0.4
  • agentkeepalive 4.2.0 -> 4.2.1
  • lru-cache 7.3.1 -> 7.4.0
  • minimass-fetch 1.4.1 -> 2.0.1

@kt3k
Copy link
Member Author

kt3k commented Mar 7, 2022

This commit breaks minipass-fetch for node compat mode

@kt3k
Copy link
Member Author

kt3k commented Mar 7, 2022

The reason was that minipass-fetch started calling http(s).request without href option since this commit, which we haven't supported yet.

@kt3k kt3k mentioned this issue Mar 7, 2022
Merged
@kt3k
Copy link
Member Author

kt3k commented Mar 7, 2022 •
edited
Loading

I wonder why this didn't break windows CI.. oh, it's entirely ignored

@kt3k kt3k closed this as completed in #2004 Mar 8, 2022
@kt3k kt3k self-assigned this Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kt3k kt3k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(node): fix http.request for minipass-fetch 2.x kt3k/deno_std
1 participant
@kt3k