Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): fix http.request for minipass-fetch 2.x #2004

Merged
merged 2 commits into from
Mar 8, 2022
Merged

fix(node): fix http.request for minipass-fetch 2.x #2004

merged 2 commits into from
Mar 8, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 7, 2022

This PR fixes the call of http.request without href option.

minipass-fetch@>2 calls http.request without href option (this commit started it).

npm started depending on minipass-fetch@2 indirectly at this commit, and that broke the integration test of npm install in compat mode in CI

closes #2001

@kt3k kt3k requested a review from bartlomieju as a code owner March 7, 2022 10:39
bartlomieju
bartlomieju approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice find

@kt3k kt3k merged commit a7872e5 into denoland:main Mar 8, 2022
@kt3k kt3k deleted the fix/fix-for-minipass-fetch-2 branch March 8, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compat: [email protected] doesn't work with compat mode
2 participants
@kt3k @bartlomieju