Skip to content

Commit

Permalink
chore(node): pin npm version to 8.5.2 in integration test (#2000)
Browse files Browse the repository at this point in the history
  • Loading branch information
kt3k authored Mar 7, 2022
1 parent 8cb37f7 commit a4f8983
Showing 1 changed file with 12 additions and 16 deletions.
28 changes: 12 additions & 16 deletions node/integrationtest/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,26 +18,22 @@ Deno.test("integration test of compat mode", {
const expressPath = join(tempDir, "node_modules", "express");

await t.step("yarn add npm express", async () => {
await exec(`deno run --compat --unstable -A ${yarnUrl} add npm`, opts);
const stat = await Deno.lstat(join(npmPath, "package.json"));
assert(stat.isFile);
// FIXME(kt3k): [email protected] doesn't work with compat mode
await exec(
`deno run --compat --unstable -A ${yarnUrl} add [email protected]`,
opts,
);
assert((await Deno.lstat(join(npmPath, "package.json"))).isFile);
await exec(`deno run --compat --unstable -A ${yarnUrl} add express`, opts);
assert((await Deno.lstat(join(expressPath, "package.json"))).isFile);
});

// FIXME(kt3k): npm in compat mode is broken in Linux and Mac
if (Deno.build.os === "windows") {
await t.step("npm install gulp", async () => {
await exec(
`deno run --compat --unstable -A ${
join(npmPath, "index.js")
} install gulp`,
opts,
);
const stat = await Deno.lstat(join(gulpPath, "package.json"));
assert(stat.isFile);
});
}
await t.step("npm install gulp", async () => {
const npmCli = join(npmPath, "index.js");
await exec(`deno run --compat --unstable -A ${npmCli} install gulp`, opts);
const stat = await Deno.lstat(join(gulpPath, "package.json"));
assert(stat.isFile);
});

await t.step("run express example app", async () => {
await Deno.writeTextFile(
Expand Down

0 comments on commit a4f8983

Please sign in to comment.