fix se_atten variable names when suffix is given #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that deepmodeling#1891 wrongly added a suffix to the variable names to make them like `filter_type_all_suffix/matrix_1_suffix`. However, it is expected to be `filter_type_all_suffix/matrix_1` which is consistent in other classes and methods. Signed-off-by: Jinzhe Zeng <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2631 +/- ##
==========================================
+ Coverage 78.58% 78.62% +0.03%
==========================================
Files 233 233
Lines 24117 24117
Branches 1409 1409
==========================================
+ Hits 18953 18962 +9
+ Misses 4804 4795 -9
Partials 360 360
☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
wanghan-iapcm
approved these changes
Jun 25, 2023
iProzd
approved these changes
Jun 25, 2023
nahso
approved these changes
Jun 25, 2023
wanghan-iapcm
pushed a commit
that referenced
this pull request
Jun 26, 2023
Merged
wanghan-iapcm
pushed a commit
that referenced
this pull request
Jul 20, 2023
Add an experimental model called pairwise DPRc, which is fragment-based and integrated with QM/MM. Compression inference and training are supported. Unit tests and documentation have been added. Some features or bugfix to implement this PR have been merged in #2549, #2600, #2601, #2604, #2631, #2635, #2665, #2666, #2667, and #2679. This PR makes some changes to `model.build_descrpt` additionally: - fix errors when the suffix is not empty - fix errors when `fparam` or `aparam` are given - support model-customized `input_map` --------- Signed-off-by: Jinzhe Zeng <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that #1891 wrongly added a suffix to the variable names to make them like
filter_type_all_suffix/matrix_1_suffix. However, it is expected to befilter_type_all_suffix/matrix_1, consistent in other descriptors and the following method.deepmd-kit/deepmd/utils/graph.py
Lines 166 to 171 in 5308c66