Fix bugs when init_frz_model using tebd. #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devel update
Devel update
Devel update
Devel update
Devel update
Devel update
Devel update
Devel update
Devel update 2.0.0 with more features
Devel update
Devel update
Devel update
Deal with the required changes, add docs, and fix bugs in UT.
Add docs to ntype and nmask in ProdEnvMatAMix. Change nmask from FPTYPE to bool. Fix bugs in toc depth.
njzjz
reviewed
Sep 3, 2022
njzjz
reviewed
Sep 6, 2022
njzjz
approved these changes
Sep 6, 2022
njzjz
reviewed
Sep 6, 2022
denghuilu
approved these changes
Sep 7, 2022
|
#1901 should fix the failed tests. |
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
Fix bugs when init_frz_model using tebd. Add init_variables for attention variables. Fix precision of self.t_bias_atom_e in se_atten.py. Change the default values in argcheck for se_atten (typos). Improve the name scope in se_atten.py. Delete some redundant variables in se_atten.py. Move tf.constant from se_a.__init__() into build. Add UTs for init_frz_model. Co-authored-by: Jinzhe Zeng <[email protected]>
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Jun 23, 2023
It seems that deepmodeling#1891 wrongly added a suffix to the variable names to make them like `filter_type_all_suffix/matrix_1_suffix`. However, it is expected to be `filter_type_all_suffix/matrix_1` which is consistent in other classes and methods. Signed-off-by: Jinzhe Zeng <[email protected]>
wanghan-iapcm
pushed a commit
that referenced
this pull request
Jun 25, 2023
It seems that #1891 wrongly added a suffix to the variable names to make them like `filter_type_all_suffix/matrix_1_suffix`. However, it is expected to be `filter_type_all_suffix/matrix_1`, consistent in other descriptors and the following method. https://github.com/deepmodeling/deepmd-kit/blob/5308c66d4f3069047af4a8aa07ece1df4b9628bc/deepmd/utils/graph.py#L166-L171 --------- Signed-off-by: Jinzhe Zeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs when init_frz_model using tebd.
Add init_variables for attention variables.
Fix precision of self.t_bias_atom_e in se_atten.py.
Change the default values in argcheck for se_atten (typos).
Improve the name scope in se_atten.py.
Delete some redundant variables in se_atten.py.
Move tf.constant from se_a.init() into build.
Add UTs for init_frz_model.