Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort aparam in the Python API #2666

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jul 10, 2023

No description provided.

Signed-off-by: Jinzhe Zeng <[email protected]>
(cherry picked from commit a2aa14e)
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (d3d3c18) 78.35% compared to head (5277869) 78.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2666      +/-   ##
==========================================
- Coverage   78.35%   78.33%   -0.02%     
==========================================
  Files         235      235              
  Lines       24473    24477       +4     
  Branches     1469     1469              
==========================================
- Hits        19175    19174       -1     
- Misses       4906     4913       +7     
+ Partials      392      390       -2     
Impacted Files Coverage Δ
deepmd/infer/deep_pot.py 82.88% <100.00%> (+0.31%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit 3a5f7cf into deepmodeling:devel Jul 11, 2023
@njzjz njzjz mentioned this pull request Jul 17, 2023
wanghan-iapcm pushed a commit that referenced this pull request Jul 20, 2023
Add an experimental model called pairwise DPRc, which is fragment-based
and integrated with QM/MM. Compression inference and training are
supported.
Unit tests and documentation have been added.

Some features or bugfix to implement this PR have been merged in #2549,
#2600, #2601, #2604, #2631, #2635, #2665, #2666, #2667, and #2679.
This PR makes some changes to `model.build_descrpt` additionally:
- fix errors when the suffix is not empty
- fix errors when `fparam` or `aparam` are given
- support model-customized `input_map`

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants