Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop flatpak hacks when they're not needed #781

Open
zeenix opened this issue May 8, 2024 · 1 comment
Open

Drop flatpak hacks when they're not needed #781

zeenix opened this issue May 8, 2024 · 1 comment
Labels
linux Issue is specific to Linux zbus Issues/PRs related to zbus crate

Comments

@zeenix
Copy link
Contributor

zeenix commented May 8, 2024 •
edited
Loading

We should drop the hacks to remove the flatpak workarounds added in #780 and #859 once the underlying issues (flatpak/xdg-dbus-proxy#21 and flatpak/xdg-dbus-proxy#46) are fixed and the fixes have reached LT releases of major distros.
@zeenix zeenix added linux Issue is specific to Linux zbus Issues/PRs related to zbus crate labels May 8, 2024
@zeenix zeenix changed the title Drop flatpak hack when it's not needed Drop flatpak hacks when it's not needed Jul 6, 2024
@zeenix zeenix changed the title Drop flatpak hacks when it's not needed Drop flatpak hacks when they're not needed Jul 6, 2024
@zeenix
Copy link
Contributor Author

zeenix commented Oct 4, 2024

Just for the record the latest xdg-dbus-proxy release 0.1.6 fixes both the issues. It's not yet widely available in major distros though. We'll probably want to wait another 6 months before removing these workarounds.

zeenix added a commit to zeenix/zbus that referenced this issue Oct 4, 2024
@zeenix
🛂 zb: Only support one authentication method at a time
23bda8e 
Now that we're down to only two authentication mechanisms with one of
them being no-authentication, this really makes sense since we can just
autodetect what authentication method to use for a specific socket type
on a specific platform.

This also simplifies the handshake logic and will allow us to pipeline the
whole client-side handshake in the future, when we can drop the
xdg-dbus-proxy [workarounds].

As they say in the famous Queen song:

Hey! One man, one goal
Ha, one mission
One heart, one soul
Just one solution
One flash of light
Yeah, one God, one vision

One flesh, one bone, one true religion
One voice, one hope, one real decision
Whoa, whoa, whoa, whoa, whoa, whoa
Give me one vision, yeah

Fixes dbus2#731.

[workarounds]: dbus2#781
@zeenix zeenix mentioned this issue Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linux Issue is specific to Linux zbus Issues/PRs related to zbus crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zeenix