💩 zb: Workaround for xdg-dbus-proxy's monotonic serial requirement #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While [the underlying issue in xdg-dbus-proxy][1] has already been fixed, it will take some time before the fix is released and is widely available. So let's add a workaround for now that makes message creation and sending an atomic operation, using an async semaphore if flatpak portal is detected. [1]: flatpak/xdg-dbus-proxy#46
zeenix
force-pushed
the
ensure-monotonic-serial
branch
from
9442e71
to
6e0c097
Compare
|
Converting to a draft to avoid accidental merge before it can be tested with different flatpak apps. |
|
Can confirm that this PR fixes the the "Invalid client serial" issue for Key Rack / oo7 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the underlying issue in xdg-dbus-proxy has already been fixed, it will take some time before the fix is released and is widely available. So let's add a workaround for now that makes message creation and sending an atomic operation, using an async semaphore if flatpak portal is detected.