Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support only 1 auth at a time #731

Closed
zeenix opened this issue Apr 23, 2024 · 0 comments · Fixed by #1041
Closed

Support only 1 auth at a time #731

zeenix opened this issue Apr 23, 2024 · 0 comments · Fixed by #1041
Labels
api break zbus Issues/PRs related to zbus crate
Milestone

Comments

@zeenix
Copy link
Contributor

zeenix commented Apr 23, 2024

In most cases (I'd say at least 95%), you just want to use EXTERNAL auth but when not, you want to use COOKIE auth so it's basically known which auth to use and zbus can decide automatically for a majority of cases (where user doesn't specify the auth). If user specifies the auth mechanism to use, IMO it's a special case and I think it's fine to only allow them to set one.

Doing so, will allow us to better pipeline the handshake process since we'll no longer have to do any ping-pong with the server anymore and send all commands (and hopefully Hello method too) in one go (reducing the context switching and syscalls).

This also would make #726 and #727 unnecessary.

@zeenix zeenix added api break zbus Issues/PRs related to zbus crate labels Apr 23, 2024
zeenix added a commit to zeenix/zbus that referenced this issue Apr 29, 2024
In favor of `auth_mechansim`. This is in preparation for dbus2#731, when we
will remove this method entirely.
@zeenix zeenix added this to the zbus-5.0 milestone Sep 6, 2024
@zeenix zeenix closed this as completed in 23bda8e Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api break zbus Issues/PRs related to zbus crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant