🛂 zb: Only support one authentication method at a time #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket impl will now inform us which authentication mechanism should be used with it. The implementation can choose this based on the socket type and the target platform. This will allow us to switch to a single mechanism for each connection in a following commit.
Now that we're down to only two authentication mechanisms with one of them being no-authentication, this really makes sense since we can just autodetect what authentication method to use for a specific socket type on a specific platform. This also simplifies the handshake logic and will allow us to pipeline the whole client-side handshake in the future, when we can drop the xdg-dbus-proxy [workarounds]. As they say in the famous Queen song: Hey! One man, one goal Ha, one mission One heart, one soul Just one solution One flash of light Yeah, one God, one vision One flesh, one bone, one true religion One voice, one hope, one real decision Whoa, whoa, whoa, whoa, whoa, whoa Give me one vision, yeah Fixes dbus2#731. [workarounds]: dbus2#781
We leave the `AuthMechanism` in the root as deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're down to only two authentication mechanisms with one of them being no-authentication, this really makes sense since we can just autodetect what authentication method to use for a specific socket type on a specific platform.
This also simplifies the handshake logic and will allow us to pipeline the whole client-side handshake in the future, when we can drop the xdg-dbus-proxy workarounds.
As they say in the famous Queen song:
Fixes #731.